Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GitHub Issue Links #345

Merged
merged 2 commits into from Jul 11, 2019

Conversation

@HaaLeo
Copy link
Contributor

commented May 7, 2019

Related Issues

Closes #340:

Changes

  • Enable to replace GitHub issue references with absolute urls
    • Supports to replace issue links of shape #7 as well as Microsoft/vscode#7
  • Do not replace anything if it is no GitHub repository
  • Added unit tests

There is no conflict between issues and pull requests because GitHub redirects issue urls automatically to prs. For example: https://github.com/microsoft/vscode-vsce/issues/248 will be redirected to https://github.com/microsoft/vscode-vsce/pulls/248

If you have any questions, do not hestiate to ask me.

HaaLeo added some commits May 7, 2019

#340:
* Enable to replace GitHub issue references with absolute urls
* Do not replace anything if it is no GitHub repository
@msftclas

This comment has been minimized.

Copy link

commented May 7, 2019

CLA assistant check
All CLA requirements met.

@joaomoreno joaomoreno self-assigned this May 7, 2019

@haydennyyy

This comment has been minimized.

Copy link

commented May 9, 2019

This looks like a really cool feature, well done

@joaomoreno joaomoreno added this to the Backlog milestone May 23, 2019

@HaaLeo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

@joaomoreno Any chance to get this one in soon? 🙂 🚀

@joaomoreno joaomoreno merged commit d999140 into microsoft:master Jul 11, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@joaomoreno

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

This is pretty cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.