Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honors --yarn flag for prepublish step #376

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@eamodio
Copy link
Contributor

commented Jul 19, 2019

Uses yarn for the prepublish step if --yarn is specified on the command line

/cc @joaomoreno

@eamodio

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

FYI, this change has a pretty big performance improvement for package/publish (at least for GitLens)

@eamodio

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

@joaomoreno any chance of something like this landing soon? Without it, packaging GitLens takes ~180s rather than ~68s. So I've been regularly hand patching it -- which is annoying because I wipe out node_modules before packaging 😄

@joaomoreno

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

Right now! Thanks!

Released in v1.66.0, builds are running https://dev.azure.com/vscode/VSCE/_build/results?buildId=23527

@joaomoreno joaomoreno added this to the July 2019 milestone Jul 23, 2019

@joaomoreno joaomoreno self-assigned this Jul 23, 2019

@joaomoreno joaomoreno merged commit 188c304 into microsoft:master Jul 23, 2019

2 checks passed

VSCE Build #20190719.1 succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.