Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when packaging an extension with an unchanged README.md #392

Merged
merged 2 commits into from Oct 11, 2019

Conversation

@tzfrs
Copy link
Contributor

tzfrs commented Oct 11, 2019

"Resolves" #391

I put "Resolves" into quotes since it's not really a bug, I just think this improves the experience. The case that a readme is unchanged was also never tested, so I added a test as well.

@joaomoreno maybe you want to have a look at this and add your 2 cents? :) thank you.

@msftclas

This comment has been minimized.

Copy link

msftclas commented Oct 11, 2019

CLA assistant check
All CLA requirements met.

@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Oct 11, 2019

Awesome, thanks! 🍻

@joaomoreno joaomoreno added this to the October 2019 milestone Oct 11, 2019
@joaomoreno joaomoreno self-assigned this Oct 11, 2019
@joaomoreno joaomoreno merged commit a154e8c into microsoft:master Oct 11, 2019
2 checks passed
2 checks passed
VSCE Build #20191011.1 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.