From f33cb5ceabf2c732fdbe7cc66d49b3ca9ea916e7 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Wed, 15 Jul 2020 05:30:14 -0700 Subject: [PATCH] Fix error telemetry issue Fixes #102558 --- .../terminal/browser/links/terminalLinkHelpers.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/vs/workbench/contrib/terminal/browser/links/terminalLinkHelpers.ts b/src/vs/workbench/contrib/terminal/browser/links/terminalLinkHelpers.ts index a5d0ae74f46a7..de8cb63d107cc 100644 --- a/src/vs/workbench/contrib/terminal/browser/links/terminalLinkHelpers.ts +++ b/src/vs/workbench/contrib/terminal/browser/links/terminalLinkHelpers.ts @@ -94,13 +94,16 @@ export function convertBufferRangeToViewport(bufferRange: IBufferRange, viewport } export function getXtermLineContent(buffer: IBuffer, lineStart: number, lineEnd: number, cols: number): string { - let line = ''; + let content = ''; for (let i = lineStart; i <= lineEnd; i++) { // Make sure only 0 to cols are considered as resizing when windows mode is enabled will // retain buffer data outside of the terminal width as reflow is disabled. - line += buffer.getLine(i)!.translateToString(true, 0, cols); + const line = buffer.getLine(i); + if (line) { + content += line.translateToString(true, 0, cols); + } } - return line; + return content; } export function positionIsInRange(position: IBufferCellPosition, range: IBufferRange): boolean {