From fe5f564db16038785936282be7f6b871f34b8bd1 Mon Sep 17 00:00:00 2001 From: Joyce Er Date: Thu, 3 Nov 2022 08:19:58 -0700 Subject: [PATCH] Attempt to fix Rust clippy lint errors (#165377) --- cli/src/self_update.rs | 2 +- cli/src/tunnels/code_server.rs | 2 +- cli/src/util/tar.rs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cli/src/self_update.rs b/cli/src/self_update.rs index 3ea8274b33839..7a5b41e83a7e7 100644 --- a/cli/src/self_update.rs +++ b/cli/src/self_update.rs @@ -150,7 +150,7 @@ fn copy_file_metadata(from: &Path, to: &Path) -> Result<(), std::io::Error> { use std::os::unix::fs::MetadataExt; let metadata = from.metadata()?; - fs::set_permissions(&to, metadata.permissions())?; + fs::set_permissions(to, metadata.permissions())?; // based on coreutils' chown https://github.com/uutils/coreutils/blob/72b4629916abe0852ad27286f4e307fbca546b6e/src/chown/chown.rs#L266-L281 let s = std::ffi::CString::new(to.as_os_str().as_bytes()).unwrap(); diff --git a/cli/src/tunnels/code_server.rs b/cli/src/tunnels/code_server.rs index 559f5e075f6d6..e19cd29d6f75f 100644 --- a/cli/src/tunnels/code_server.rs +++ b/cli/src/tunnels/code_server.rs @@ -352,7 +352,7 @@ fn install_server( unzip_downloaded_release(compressed_file, &paths.server_dir, SilentCopyProgress())?; - match fs::remove_file(&compressed_file) { + match fs::remove_file(compressed_file) { Ok(()) => {} Err(e) => { if e.kind() != ErrorKind::NotFound { diff --git a/cli/src/util/tar.rs b/cli/src/util/tar.rs index b5884e67afd71..77dd67abbb08f 100644 --- a/cli/src/util/tar.rs +++ b/cli/src/util/tar.rs @@ -87,7 +87,7 @@ where }); if let Some(p) = path.parent() { - fs::create_dir_all(&p) + fs::create_dir_all(p) .map_err(|e| wrap(e, format!("could not create dir for {}", p.display())))?; }