Right Mouse Click is broken

[jtsom]

Issue Type: Bug

Right click anywhere in a document and the context menu does not appear. An error is reported in the developer tools console.

VS Code version: Code - Exploration 1.47.0-exploration (23d15c6, 2020-06-24T17:10:42.684Z)
OS version: Darwin x64 19.5.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2600)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	2, 2, 2
Memory (System)	32.00GB (5.23GB free)
Process Argv
Screen Reader	no
VM	13%

Extensions: none

[jtsom]

Also, once the error is triggered, hover tool tips don't show anymore.

[deepak1556]

Thanks for trying out the exploration build

@bpasero this another one of the breaking change from Electron 9 https://github.com/electron/electron/blob/master/docs/breaking-changes.md#behavior-changed-sending-non-js-objects-over-ipc-now-throws-an-exception , ipc serialization will behave like postmessage and it throws if there is an error.

I am yet to make a tracking issue to cover this change.

[bpasero]

@deepak1556 I do not fully understand, the contents we send over are JSON serializable, are you saying we have to send strings now?

The object is of this shape:

vscode/src/vs/base/parts/contextmenu/common/contextmenu.ts

Lines 6 to 21 in e5d08ae

	export interface ICommonContextMenuItem {
	label?: string;
	type?: 'normal' | 'separator' | 'submenu' | 'checkbox' | 'radio';
	accelerator?: string;
	enabled?: boolean;
	visible?: boolean;
	checked?: boolean;
	}
	export interface ISerializableContextMenuItem extends ICommonContextMenuItem {
	id: number;
	submenu?: ISerializableContextMenuItem[];
	}

[bpasero]

@deepak1556 ping

[bpasero]

Oh I see it now, there is a function sneaking in via options...