Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doing a performance profiling freezes notebook and defers all mouse events until the profile has stopped #115091

Closed
Tyriar opened this issue Jan 26, 2021 · 4 comments
Assignees
Labels
chrome-devtools Issues related to developer tools upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 26, 2021

Testing #114969

This issue makes it touch to look into scroll/layout perf of notebooks

Repro:

  1. Open an ipynb
  2. Open devtools
  3. Do a perf profile
  4. Use the mouse wheel in the editor, nothing happens
  5. Stop the profile, all wheel events are triggered

recording (40)

Version: 1.53.0-insider (user setup)
Commit: 1a9dd75
Date: 2021-01-26T05:13:59.356Z
Electron: 11.2.1
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Windows_NT x64 10.0.19042

@rebornix
Copy link
Member

rebornix commented Feb 3, 2021

@deepak1556 do you have ideas about this?

@rebornix rebornix added the chrome-devtools Issues related to developer tools label Feb 3, 2021
@deepak1556
Copy link
Contributor

Is it better when you start the app with --disable-renderer-accessibility ?

@Tyriar
Copy link
Member Author

Tyriar commented Feb 3, 2021

@deepak1556 no it still happens, I ran it like this:

$ c --disable-renderer-accessibility
Warning: 'disable-renderer-accessibility' is not in the list of known options, but still passed to Electron/Chromium.

I don't see it on the renderer's argv, does it only get applied to the main proc?

image

@rebornix rebornix added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Oct 11, 2021
@rebornix rebornix removed their assignment Oct 22, 2021
@deepak1556
Copy link
Contributor

Issue does not repro with recent versions.

@deepak1556 deepak1556 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chrome-devtools Issues related to developer tools upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants