Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook editors have an undefined viewColumn #115704

Closed
alyssajotice opened this issue Feb 3, 2021 · 3 comments
Closed

Notebook editors have an undefined viewColumn #115704

alyssajotice opened this issue Feb 3, 2021 · 3 comments
Assignees
@jrieken
Labels
author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality notebook verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2021

Comments

@alyssajotice
Copy link

  • VSCode Version: 1.53.0-insider
  • OS Version: Windows 10

The editors in the list of vscode.window.visibleNotebookEditors do not have a defined viewColumn. The cells included in the list of vscode.window.visibleTextEditors also have undefined view columns. Therefore, there is no way to figure out where the notebook is open for the user. This value should be defined.

image

cc @daytonellwanger @rebornix
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook labels Mar 26, 2021
@rebornix rebornix added this to the April 2021 milestone Mar 26, 2021
@rebornix rebornix assigned jrieken and unassigned rebornix Mar 30, 2021
@jrieken jrieken changed the title Notebook documents have an undefined viewColumn Notebook editors have an undefined viewColumn Mar 30, 2021
@jrieken
Copy link
Member

jrieken commented Mar 30, 2021

YEs - this isn't implemented. Only the API has been spec'd for some reason

@jrieken jrieken added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Mar 30, 2021
jrieken added a commit that referenced this issue Mar 31, 2021
@jrieken
assert that we have static view columns
407a0e3 
#115704
jrieken added a commit that referenced this issue Mar 31, 2021
@jrieken
update notebook editor view column when moving editors, #115704
ca980ec
@jrieken
Copy link
Member

jrieken commented Mar 31, 2021

This will be working in next insiders but we don't have the equivalent of onDidChangeTextEditorViewColumn and I am not yet planning on adding that

@jrieken jrieken closed this as completed Mar 31, 2021
@jrieken jrieken added author-verification-requested Issues potentially verifiable by issue author verification-needed Verification of issue is requested labels Apr 27, 2021
@roblourens roblourens added the verified Verification succeeded label Apr 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality notebook verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2021
Development

No branches or pull requests
5 participants
@roblourens @rebornix @jrieken @alyssajotice and others