Cells aren't highlighted when revealing in outline

[roblourens]

• Open a notebook
• Open the outline and use arrow keys
• Cells are revealed when selected in the outline but previously they got a yellow bg highlight, now there is no highlight

Maybe related to #122720 somehow

[jrieken]

Cells are revealed when selected in the outline but previously they got a yellow bg highlight, now there is no highlight

Only quick outline and breadcrumbs do that. The outline view doesn't do this - afaik never did. @roblourens what which outline do you mean? view or quick?

[roblourens]

Quick outline and breadcrumbs. Today I see that I get the background highlight on code cells but not markdown cells. Was only using markdown notebook last night. I don't know whether we highlighted markdown cells previously.

[jrieken]

Quick outline and breadcrumbs. Today I see that I get the background highlight on code cells but not markdown cells.

Yeah, I am also seeing that (and have files a dupe issue ;-))

[rebornix]

I think it's an issue with the custom markdown renderer. I fixed this before but not sure why it regressed now.

[rebornix]

it's the Shadow DOM :) We applied class names on the container, but now the markdown previews are rendered in the Shadow DOM and styles will not be applied

vscode/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts

Lines 780 to 787 in d639345

	case 'decorations':
	{
	const outputContainer = document.getElementById(event.data.cellId);
	outputContainer?.classList.add(...event.data.addedClassNames);
	outputContainer?.classList.remove(...event.data.removedClassNames);
	}
	break;