Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a vscode://file to open in the window that has the workspace opened #150078

Closed
zhixiaoqiang opened this issue May 21, 2022 · 11 comments
Closed
Labels
feature-request Request for new features or functionality workbench-os-integration Native OS integration issues workbench-workspace Workspace issues

Comments

@zhixiaoqiang
Copy link

Question

vscode://file will open active window, not the workspace window

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.67.2
  • OS Version: MacOS Big Sur 11.2.3 M1

Steps to Reproduce:

  1. Install Visual Studio Code
  2. browser input vscode://file/xx
  3. waiting for results
@zhixiaoqiang zhixiaoqiang changed the title via vscode://file doest properly open workspace window like code -g` does via vscode://file doesn't properly open workspace window like code -g does May 21, 2022
@joaomoreno joaomoreno assigned bpasero and unassigned joaomoreno May 23, 2022
@bpasero
Copy link
Member

bpasero commented May 27, 2022

I guess you meant to say code -r? Is the intent to forcefully open a file link in the last active window?

@bpasero bpasero added the info-needed Issue requires more information from poster label May 27, 2022
@zhixiaoqiang
Copy link
Author

zhixiaoqiang commented May 27, 2022

I guess you meant to say code -r? Is the intent to forcefully open a file link in the last active window?

no, I mean it should be opened in the code corresponding workspace window, instead of in the last active window

@zhixiaoqiang
Copy link
Author

I guess you meant to say code -r? Is the intent to forcefully open a file link in the last active window?

no, I mean it should be opened in the code corresponding workspace window, instead of in the last active window

Of course, if there is no matching workspace window then open from the active window

@zhixiaoqiang
Copy link
Author

I've read the relevant code, but haven't been able to solve the problem,😩

@bpasero
Copy link
Member

bpasero commented May 27, 2022

@zhixiaoqiang ok to clarify, you expect these files to open in the window that has the parent folder or any parent folder opened as workspace?

@zhixiaoqiang
Copy link
Author

@zhixiaoqiang ok to clarify, you expect these files to open in the window that has the parent folder or any parent folder opened as workspace?

yes

@bpasero bpasero added feature-request Request for new features or functionality workbench-window Window management workbench-os-integration Native OS integration issues and removed info-needed Issue requires more information from poster workbench-window Window management labels May 27, 2022
@bpasero bpasero removed their assignment May 27, 2022
@bpasero bpasero changed the title via vscode://file doesn't properly open workspace window like code -g does Allow a vscode://file to open in the window that has the workspace opened May 27, 2022
@bpasero
Copy link
Member

bpasero commented May 27, 2022

//cc @joaomoreno , somewhat similar to your recent new option to force a new window, maybe this could be a query parameter to force picking an existing window that matches best.

@VSCodeTriageBot VSCodeTriageBot added this to the Backlog Candidates milestone May 27, 2022
@VSCodeTriageBot
Copy link
Collaborator

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@bpasero bpasero added the workbench-workspace Workspace issues label May 28, 2022
@ptim
Copy link

ptim commented Jun 20, 2022

Came here to ask the same thing! I'm preferring to use a vscode:// URL because it is noticeably faster than opening from the CLI, on my system (MacOS 11.6.4)

Maybe a query string might work? vscode://file/c:/myProject/package.json:5:10?workspace=c:/myProject/multiroot.code-wokspace

@VSCodeTriageBot
Copy link
Collaborator

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@VSCodeTriageBot
Copy link
Collaborator

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality workbench-os-integration Native OS integration issues workbench-workspace Workspace issues
Projects
None yet
Development

No branches or pull requests

5 participants