Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare for server profiles #174232

Merged
merged 3 commits into from Feb 14, 2023
Merged

prepare for server profiles #174232

merged 3 commits into from Feb 14, 2023

Conversation

sandy081
Copy link
Member

  • make state service available in server
  • Intrdouce save stragey in state service - state shall be saved immediately in server
  • use UserDataProfilesService that can save profiles in server

@sandy081
prepare for server profiles
95666b5 
- make state service available in server
- Intrdouce save stragey in state service - state shall be saved immediately in server
- use UserDataProfilesService that can save profiles in server
@sandy081 sandy081 self-assigned this Feb 13, 2023
@sandy081 sandy081 enabled auto-merge (squash) February 13, 2023 09:55
@VSCodeTriageBot VSCodeTriageBot added this to the February 2023 milestone Feb 13, 2023
bpasero
bpasero requested changes Feb 13, 2023
View reviewed changes
src/vs/platform/state/node/state.ts Outdated Show resolved Hide resolved
src/vs/code/node/cliProcessMain.ts Show resolved Hide resolved
src/vs/server/node/serverServices.ts Outdated Show resolved Hide resolved
src/vs/platform/state/node/state.ts Outdated Show resolved Hide resolved
src/vs/platform/state/node/stateService.ts Outdated Show resolved Hide resolved
@bpasero
Copy link
Member

bpasero commented Feb 13, 2023

Btw I only looked at the changes in state service and users, not in the larger profile related changes.

@sandy081
Copy link
Member Author

@bpasero updated the changes and reviewing state service and its users shall be good. Thanks.

bpasero
bpasero requested changes Feb 14, 2023
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more things:

  • have state.test.ts also test the immediate save mode
  • should we be setting IStateReadService also in main.ts alongside IStateService? this would reduce the chances of breakage if code depends on the readonly service in main

@sandy081
- add tests
2220560 
- register IStateReadService in main
@sandy081
Copy link
Member Author

@bpasero - Done

@sandy081 sandy081 merged commit 11fcbd0 into main Feb 14, 2023
@sandy081 sandy081 deleted the sandy081/stable-tarantula branch February 14, 2023 07:58
c-claeys pushed a commit to c-claeys/vscode that referenced this pull request Feb 16, 2023
@sandy081 @c-claeys
prepare for server profiles (microsoft#174232)
455f734 
* prepare for server profiles
- make state service available in server
- Intrdouce save stragey in state service - state shall be saved immediately in server
- use UserDataProfilesService that can save profiles in server

* feedback

* - add tests
- register IStateReadService in main
@sbatten sbatten mentioned this pull request Mar 6, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

Assignees

@sandy081 sandy081

Labels
None yet
Projects
None yet
Milestone
February 2023
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sandy081 @bpasero @VSCodeTriageBot