introduce a SemanticSimilarity provider model #179640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Apr 10, 2023
roblourens
reviewed
Apr 10, 2023
| @@ -94,18 +94,21 @@ export function raceCancellationError<T>(promise: Promise<T>, token: Cancellatio | |||
| } | |||
|
|
|||
| /** | |||
| * Returns as soon as one of the promises is resolved and cancels remaining promises | |||
| * Returns as soon as one of the promises resolves or rejects and cancels remaining promises | |||
| */ | |||
| export async function raceCancellablePromises<T>(cancellablePromises: CancelablePromise<T>[]): Promise<T> { | |||
There was a problem hiding this comment.
I think this is an improvement, thanks, but it is a behavior change so if you haven't already, make sure you take a look at the other places it's used and try to check whether that might be an issue
There was a problem hiding this comment.
Yeah it's only used in one other place and I think based on the code it seems ok. @sandy081 FYI
roblourens
reviewed
Apr 10, 2023
src/vs/workbench/services/semanticSimilarity/common/semanticSimilarityService.ts
Show resolved
Hide resolved
roblourens
reviewed
Apr 10, 2023
src/vs/workbench/services/semanticSimilarity/common/semanticSimilarityService.ts
Outdated
Show resolved
Hide resolved
roblourens
reviewed
Apr 10, 2023
src/vs/workbench/services/semanticSimilarity/common/semanticSimilarityService.ts
Show resolved
Hide resolved
roblourens
approved these changes
Apr 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.