Build task not available when pressing cmd+shift+B immediately after window opens

[roblourens]

Maybe related to #173184

• Quit vscode
• Open vscode
• When the window for the vscode repo opens, immediately press cmd+shift+B. This is a multi-root workspace with vscode and one other repo, if it mattters
• On the first try, I get this

• On the second try, I get this, where the primary "VS Code - Build". If I run a task, then press cmd+shift+B again, that build task will then show up

This is what I see when I wait a bit after starting vscode before pressing cmd+shift+B for the first time, all tasks are available

What I wish would happen is that it would just run the "VS Code - Build" task automatically, but that's a different issue

[meganrogge]

@roblourens does your other repo have a default build task as well?

[meganrogge]

I can repro in a multi root repo but not when I have a single folder open. I think this might be by design.

[roblourens]

Yes it also has a default build task

[meganrogge]

That's the issue. Since there are several, we don't know which one you want to run. Thus the quick pick

[roblourens]

There are two, but you're showing me like 15 tasks. But that's not the real problem in this issue, the problem is the first two screenshots where it doesn't show up at all.

[meganrogge]

That case occurs when it takes more than 200 ms to get the task quick pick entries.

vscode/src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts

Line 2647 in 2959f41

const entries: (ITaskQuickPickEntry | IQuickPickSeparator)[] | undefined = await raceTimeout(this._createTaskQuickPickEntries(resolvedTasks, group, sort, selectedEntry), 200, () => undefined);

[roblourens]

I messed with the code to force that call to time out, and when that happens, I see the quick pick not show up at all

[weartist]

Is it possible to increase the waiting time to get entries somewhat?

[joaomoreno]

Just hit this but during a long running session, not after window opening. Unsure of what happened to get to that state:

Screen.Recording.2023-06-09.at.09.40.12.mov

[joaomoreno]

Very consistent repro for me, not timing dependent:

1. Start VS Code in vscode
2. Cmd Shift B to start default build tasks. Wait for all compile jobs to finish.
3. Reload workbench
4. Press Cmd Shift B once again.

🐛 VS Code no longer knows what's the default build task.

[joaomoreno]

Something else I notice after reloading, the ✔️ check mark of a successful build state is gone and the 🛠️ icon is shown instead:

[meganrogge]

@joaomoreno after your above steps, does the quick pick open?

also, when those tasks are there with the 🛠 icon, are they reconnected to?

[meganrogge]

here's what I'm seeing - I'll keep trying to repro
https://github.com/microsoft/vscode/assets/29464607/108e95b5-92ab-43e4-9053-6bdb156f0866

[joaomoreno]

Yes, the result of step 4 is:

[meganrogge]

can repro when I do this

[meganrogge]

Ok - here's the issue - when the build command is triggered before the default build task has been reconnected to, that request is processed eventually after the tasks have been reconnected to. But once again, that only occurs when there's no default build task - and not sure why that is

Edit: that wasn't the issue

[roblourens]

I have this set, dunno if that's part of it "task.experimental.reconnection": false,

[meganrogge]

maybe related #179684

[meganrogge]

yep, pretty sure this is related - when I reproduced, the tasks length was 0

/duplicate #179684

reopen if you hit it again

[meganrogge]

Very consistent repro for me, not timing dependent:

1. Start VS Code in vscode
2. Cmd Shift B to start default build tasks. Wait for all compile jobs to finish.
3. Reload workbench
4. Press Cmd Shift B once again.

🐛 VS Code no longer knows what's the default build task.

This does not reproduce for me.

[meganrogge]

/duplicate #173384