-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to connect to the remote extension host server (Error: Not an authority that can be resolved!) on 1.80.0 but not on earlier versions #187202
Comments
possibly related? #185169 |
I think i have a fix
|
@roblourens what do you think of the approach here? This should only be a code path one could hit by manually opening an ssh url. |
@connor4312 Hi. Nesting remote authorities with Could you revert this feature until we find solution that works for anyone, please? |
This bug has been fixed in the latest release of VS Code Insiders! @rwdzero, you can help us out by commenting If things still don't seem right, please ensure you're on version ad791ef of Insiders (today's or later - you can use Happy Coding! |
/verified |
What changed here @connor4312? Are you using the Also @rwdzero you don't need the username when it's already in your ssh config. And when we create this sort of URI internally, we base64-encode the user+host rather than put special characters into the URI. Actually I'm sort of surprised that we parsed it correctly before. |
Hey @roblourens thanks for the reply, I tried using Thanks for the suggestion for including the user in the ssh config but unfortunately our use case depends on us not being able to modify this file. We based on our implementation on this issue microsoft/vscode-remote-release#656 (comment) |
Yea, the |
I see, and the fix is to not try to split it on Ok, yeah @rwdzero the base64-encoded version is not a format that is really exposed to the user anywhere. If it helps in the short-term, the logic is like |
A little nitpick - this is not base64-encoding, but simple hex-encoding. And struct also includes |
/verified |
Does this issue occur when all extensions are disabled?: Yes
Version: 1.80.0 (Universal)
Commit: 660393d
Date: 2023-07-04T13:39:33.766Z (2 days ago)
Electron: 22.3.14
ElectronBuildId: 21893604
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Darwin arm64 22.5.0
Steps to Reproduce:
eg:
vscode://vscode-remote/ssh-remote+devzero@ybsvmibl.devinfra.dev0.run/home/devzero/projects?windowId=_blank
I get the following error message
I can work around by either:
downgrading vscode to May 2023 (version 1.79)
manually adding entry to my ~/.ssh/config
working ssh config
vscode dev console logs
The text was updated successfully, but these errors were encountered: