Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to configure long commit warning length #18807

Closed
adamweeks opened this issue Jan 19, 2017 · 11 comments

Comments

@adamweeks
Copy link

@adamweeks adamweeks commented Jan 19, 2017

It would be nice to configure how long a commit message is before it displays the warning. Some repos I work on allow a 75 char line length, while others allow 100. I know we can enable/disable via git.enableLongCommitWarning config. Would be nice to add one more config for length.

  • VSCode Version: 1.8.1
  • OS Version: macOS Sierra

Steps to Reproduce:

  1. Enter a commit message longer than 50 characters.
  2. Observe warning.
@joaomoreno joaomoreno added this to the Backlog milestone Jan 20, 2017
@joaomoreno joaomoreno removed their assignment Jan 20, 2017
@zbjornson

This comment has been minimized.

Copy link

@zbjornson zbjornson commented Feb 15, 2017

GitHub shows the first 70 characters and GitLab shows the first 80. Would be nice to have this configurable so users can work to those limits.

@jdforsythe

This comment has been minimized.

Copy link

@jdforsythe jdforsythe commented Mar 9, 2017

I was just about to post this as a request.

@jcbp

This comment has been minimized.

Copy link

@jcbp jcbp commented Feb 16, 2018

I think that if the warning only shows a character count instead of the remaining characters there is no needs to configure the characters warning limit. It could just show the text length number.

@pradyunsg

This comment has been minimized.

@mittalyashu

This comment has been minimized.

Copy link

@mittalyashu mittalyashu commented Jun 26, 2018

VS Code (only write 72 characters)

code_2018-06-26_15-24-02

Atom (write the description to infinite length)

2018-06-26_15-24-53

@FranklinYu

This comment has been minimized.

Copy link

@FranklinYu FranklinYu commented Jun 26, 2018

@mittalyashu How is that related to this issue?

@pradyunsg

This comment has been minimized.

Copy link

@pradyunsg pradyunsg commented Jun 26, 2018

Moreover, you can write commit messages longer than 72 characters. If you don't want that warning, there's a configuration option to disable it.

@mittalyashu

This comment has been minimized.

Copy link

@mittalyashu mittalyashu commented Jun 27, 2018

Moreover, you can write commit messages longer than 72 characters. If you don't want that warning, there's a configuration option to disable it.

@pradyunsg, how to do it?

@pradyunsg

This comment has been minimized.

Copy link

@pradyunsg pradyunsg commented Jun 27, 2018

// Controls when to show commit message input validation.
"git.inputValidation": "warn"

It can take the values always, warn, off. To disable it, use off.

@joaomoreno joaomoreno added this to the September 2018 milestone Sep 18, 2018
@joaomoreno

This comment has been minimized.

Copy link
Member

@joaomoreno joaomoreno commented Sep 18, 2018

Starting next release, you can control this with git.inputValidationLength.

@pradyunsg

This comment has been minimized.

Copy link

@pradyunsg pradyunsg commented Sep 18, 2018

@joaomoreno Awesome! Thanks for this!

@jrieken jrieken added the verified label Sep 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
9 participants
You can’t perform that action at this time.