Skip to content

Allow WorkspaceEditMetadata to control whether changes are grouped by label by default #207580

@DanTup

Description

@DanTup

Using WorkspaceEditEntryMetadata (to set needsConfirmation) requires setting a string label on the changes, but by default these labels are not visible in the UI. You have to explicitly toggle on grouping:

group.mp4

It would be nice if we could set the default behaviour on the WorkspaceMetadata because some kinds of edits are much better grouped together (for example fixing multiple lints in a single action, grouped by lint name).

VS Code's LSP client is already telling servers that changes will be grouped (although the spec is a bit vague about whether this is default or just an option):

https://github.com/microsoft/vscode-languageserver-node/blob/691fd5d3fabeed5ed8ff9c3608f2d306cb07717e/client/src/common/client.ts#L1837

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions