Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't update disabled extensions #22461

Closed
xavdid opened this issue Mar 11, 2017 · 6 comments · Fixed by #58723
Closed

Don't update disabled extensions #22461

xavdid opened this issue Mar 11, 2017 · 6 comments · Fixed by #58723
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded

Comments

@xavdid
Copy link

xavdid commented Mar 11, 2017

There seems to be a functional difference installed extensions disabled on a workspace level (they show up in settings). In the case of an extension disabled through the UI, I don't need it kept up-to-date until it's re-enableld through the UI.

As of now, when an extension is disabled it still gets counted in the sidebar number for "extensions waiting to update". If I've disabled an extension, it would be nice if it's out of sight, out of mind.

  • VSCode Version: Version 1.10.2 (1.10.2)
  • OS Version: macOS 10.12.2

Steps to Reproduce:

  1. Install any extension
  2. Hit Disable in the extensions panel
  3. Wait for extension to update
  4. Extension is shown as both disabled, and needing an update. There's a blue number shown in the sidebar for a disabled extension.
@ramya-rao-a ramya-rao-a added the extensions Issues concerning extensions label Mar 11, 2017
@sandy081 sandy081 added the feature-request Request for new features or functionality label Mar 13, 2017
@sandy081 sandy081 added this to the Backlog milestone Mar 13, 2017
@ramya-rao-a ramya-rao-a assigned ramya-rao-a and unassigned sandy081 Aug 9, 2018
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, On Deck Aug 9, 2018
@ParkourKarthik
Copy link
Contributor

ParkourKarthik commented Aug 16, 2018

I'd like to make a PR for this :)

@ParkourKarthik
Copy link
Contributor

ParkourKarthik commented Aug 16, 2018

From my understanding, the below are to be done:

  • The disabled extensions should be hidden by default in the extension sidebar.
  • Any extension search except '@disabled' (such as '@outdated') should not show the disabled extensions.
  • Check for Updates and Update all Extensions should not consider the disabled extensions.

@ramya-rao-a Let me know your view.

Help: Currently, the debugger instance (Launch VS Code) doesn't show any extensions from the marketplace. Tip on how to debug extensions properly would be very much appreciated :)

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Aug 16, 2018

The disabled extensions should be hidden by default in the extension sidebar.

No. The default view of the extensions viewlet already has a "disabled" section, and that will continue to show the disabled extensions. Same goes for when user types @disabled

Any extension search except '@disabled' (such as '@outdated') should not show the disabled extensions

No. Only '@outdated' should not show disabled extensions

Check for Updates and Update all Extensions should not consider the disabled extensions.

Yes.

Additionally, the label Update to ... on the extension should not appear if the extension is disabled.

Currently, the debugger instance (Launch VS Code) doesn't show any extensions from the marketplace

Did it work before when you were working on the other PR on outdated extensions?

@ParkourKarthik
Copy link
Contributor

ParkourKarthik commented Aug 16, 2018

Did it work before when you were working on the other PR on outdated extensions?

No it was not working. I managed to test it alernatively by modifying the code, but not very much related to realtime!

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Aug 16, 2018

Ah! In that case, never mind. To display extensions when running VS Code from source, we need the gallery service url which is considered proprietary and legally we cannot share that. It can only be shipped as part of the product.

Sorry for misleading you into taking this up.

@ramya-rao-a ramya-rao-a modified the milestones: On Deck, September 2018 Sep 14, 2018
ramya-rao-a added a commit that referenced this issue Sep 20, 2018
* Dont update disabled extensions #22461

* Include disabled extensions in update notification and the update button

* Show same msg for badge and check extension updates cmd

* Refactor

* Revert "Refactor"

This reverts commit a68f83f.

* Revert "Show same msg for badge and check extension updates cmd"

This reverts commit 62faecd.
@ramya-rao-a ramya-rao-a added the verification-needed Verification of issue is requested label Sep 24, 2018
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Sep 25, 2018

Verification Steps

Disable auto-update, install older versions of say 3 extensions, disable one of them

  • The badge on the Extensions icon should include only the enabled outdated extensions.
  • Run the Check for extension updates command. The resulting notification should show the same split

Repeat the above for different numbers of enabled/disabled outdated extensions (0, 1 & more)

@sbatten sbatten added the verified Verification succeeded label Sep 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants