-
Notifications
You must be signed in to change notification settings - Fork 28.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't update disabled extensions #22461
Comments
I'd like to make a PR for this :) |
From my understanding, the below are to be done:
@ramya-rao-a Let me know your view. Help: Currently, the debugger instance ( |
No. The default view of the extensions viewlet already has a "disabled" section, and that will continue to show the disabled extensions. Same goes for when user types @disabled
No. Only '@outdated' should not show disabled extensions
Yes. Additionally, the label
Did it work before when you were working on the other PR on outdated extensions? |
No it was not working. I managed to test it alernatively by modifying the code, but not very much related to realtime! |
Ah! In that case, never mind. To display extensions when running VS Code from source, we need the gallery service url which is considered proprietary and legally we cannot share that. It can only be shipped as part of the product. Sorry for misleading you into taking this up. |
* Dont update disabled extensions #22461 * Include disabled extensions in update notification and the update button * Show same msg for badge and check extension updates cmd * Refactor * Revert "Refactor" This reverts commit a68f83f. * Revert "Show same msg for badge and check extension updates cmd" This reverts commit 62faecd.
Verification Steps Disable auto-update, install older versions of say 3 extensions, disable one of them
Repeat the above for different numbers of enabled/disabled outdated extensions (0, 1 & more) |
There seems to be a functional difference installed extensions disabled on a workspace level (they show up in settings). In the case of an extension disabled through the UI, I don't need it kept up-to-date until it's re-enableld through the UI.
As of now, when an extension is disabled it still gets counted in the sidebar number for "extensions waiting to update". If I've disabled an extension, it would be nice if it's out of sight, out of mind.
Version 1.10.2 (1.10.2)
10.12.2
Steps to Reproduce:
Disable
in the extensions panelThe text was updated successfully, but these errors were encountered: