Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default node.js debug args is deprecated when update to node.js 8.0 #28223

Closed
yujiahaol68 opened this issue Jun 8, 2017 · 5 comments
Closed

default node.js debug args is deprecated when update to node.js 8.0 #28223

yujiahaol68 opened this issue Jun 8, 2017 · 5 comments
Assignees
@roblourens
Labels
*as-designed Described behavior is as designed

Comments

@yujiahaol68
Copy link

  • VSCode Version: 1.12.2
  • OS Version: macOS 10.11.6

Steps to Reproduce:

  1. run vscode debugger under node.js 8.0 and can find
    (node:2224) [DEP0062] DeprecationWarning: node --inspect --debug-brk is deprecated. Please use node --inspect-brk instead. IN CONSOLE
@roblourens
Copy link
Member

This is expected. The message is hidden in 1.13

@roblourens roblourens added the *as-designed Described behavior is as designed label Jun 8, 2017
@jens1o
Copy link
Contributor

jens1o commented Jun 8, 2017

Fixing a bug by suppressing a warning, sorry?

@roblourens
Copy link
Member

roblourens commented Jun 8, 2017 •
edited

It's not a bug, it's a valid way to put node 8 in debug mode, which they only kept to make life easier for IDEs. See nodejs/node#12949 and related issues. Also I have #27731 to make version detection more sophisticated in the future and try to use --inspect-brk.

@jens1o
Copy link
Contributor

jens1o commented Jun 8, 2017

Okay, now I got it. Apologize. :/

@roblourens
Copy link
Member

No worries, I know it doesn't look very good... That warning was added about 12 hours before node 8 final was out the door 😁

@weinand weinand mentioned this issue Aug 15, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
*as-designed Described behavior is as designed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@roblourens @yujiahaol68 @jens1o