Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop supporting debug.logToDebugConsole command #34700

Closed
isidorn opened this issue Sep 20, 2017 · 12 comments
Closed

Stop supporting debug.logToDebugConsole command #34700

isidorn opened this issue Sep 20, 2017 · 12 comments
Assignees
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Sep 20, 2017

Currently we support a 'debug.logToDebugConsole' command.
https://github.com/Microsoft/vscode/blob/a38db8e0a5ca9b651fd0484faefb17d706400cac/src/vs/workbench/parts/debug/electron-browser/debugCommands.ts#L25

Instead we should introduce API and deprecate this command.

@isidorn isidorn added debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues labels Sep 20, 2017
@isidorn isidorn added this to the October 2017 milestone Sep 20, 2017
@isidorn
Copy link
Contributor Author

isidorn commented Sep 29, 2017

Removing this only makes sense in november. First in october we have to create a solution for this using the debug api.

@weinand
Copy link
Contributor

weinand commented Sep 29, 2017

I will do this on October 23 ;-)

@isidorn
Copy link
Contributor Author

isidorn commented Sep 29, 2017

I can also look into this, just wrote down a note for myself :)

@weinand
Copy link
Contributor

weinand commented Oct 23, 2017

I've created an API request for this.

@weinand weinand removed their assignment Oct 23, 2017
@weinand weinand modified the milestones: November 2017, Backlog Nov 7, 2017
@weinand
Copy link
Contributor

weinand commented Nov 7, 2017

Since the API will be proposed in November, we cannot delete this in November.

@isidorn
Copy link
Contributor Author

isidorn commented Nov 7, 2017

@weinand should I create and assign this to the December milestone?

@weinand
Copy link
Contributor

weinand commented Nov 7, 2017

Let's wait until we know more about Xmas...

@Alphapage
Copy link

It seems to only support string message, but I need to display an object to be able to navigate properties as we do when using "Debugger evaluation" in vscode.
I didn't find a way to do this from an extension. Is it possible ?

@isidorn
Copy link
Contributor Author

isidorn commented Dec 5, 2017

@Alphapage That is only possible from a debug adapter. As an example, you can checkout node debug 2 and find when he sends the variableReference in the OutputEvent if that is what you are looking for.

@weinand
Copy link
Contributor

weinand commented Dec 5, 2017

@Alphapage expandable objects need an active debug session behind them (so that the UI can request more data on expand). When outputting an object from an extension, then there is not necessarily a debug session active.
So constraining the API to string is intentional.

@Alphapage
Copy link

As you told, I think I was going to the wrong direction: I just need to add an UI panel to the extension to be able to navigate the object.
Thank you very much.

@isidorn
Copy link
Contributor Author

isidorn commented May 11, 2018

This was done in January / February it seems

@isidorn isidorn closed this as completed May 11, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

No branches or pull requests

3 participants