Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upOn macOS the behavior for Cmd+E is incorrect #44093
Comments
This comment has been minimized.
This comment has been minimized.
|
Relevant line in the code: Should change to:
|
This comment has been minimized.
This comment has been minimized.
|
@vincentisambart Could you edit the title of this issue to emphasize that it's related to the focus? The issue is also unrelated to macOS. Perhaps something like "Cmd+E (action.findWithSelection) should not focus the find widget". |
This fixes microsoft#44093
This comment has been minimized.
This comment has been minimized.
|
Are there any plans on merging a fix for this issue? Addressing this issue would go a long way to making Cmd-E in vscode work the way long time Mac users expect. |
This comment has been minimized.
This comment has been minimized.
|
This should also appear in the menu. Here are some examples -- also to portray how prevalent this feature is, and implemented in a common way in seemingly everything but VS Code. Xcode: Find > Use Selection for Find ⌘E Note that ⇧⌘E should be Use Selection for Replace to match other Mac apps. (as per my post to #69498) |
This comment has been minimized.
This comment has been minimized.
|
Thanks all for your contribution on this topic. Considering this command is only registered with keybindings CMD+E on macOS, I think it makes sense to align it with all other applications on macOS. CMD+E won't focus on the find widget from tomorrow's Insiders. While users can still use CMD+F with seed find from selection to archive previous experience. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Thank you! This one little fix will drastically improve my experience using VS Code. |
Issue Type
Bug
Description
On most macOS applications (for example TextEdit or Xcode), Cmd+E sets the find clipboard to what is selected without changing the focus (in fact it doesn't even make the search bar appear).
VS Code makes the search bar appear and set the focus to it.
Having the search bar appearing is minor, but if you are used to the standard behavior, not having the editor keep the focus on the editor is pretty disturbing.
VS Code Info
VS Code version: Code 1.20.1 (f88bbf9, 2018-02-13T15:23:28.607Z)
OS version: Darwin x64 17.4.0
System Info
Extensions (3)