Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zen mode restore setting restores only full-screen #44652

Closed
mhxion opened this issue Feb 27, 2018 · 8 comments
Closed

Zen mode restore setting restores only full-screen #44652

mhxion opened this issue Feb 27, 2018 · 8 comments

Comments

@mhxion
Copy link

@mhxion mhxion commented Feb 27, 2018

  • VSCode Version: 1.20.1
  • OS Version: Linux Mint 18.3 Cinnamon 3.6.7 64-bit

Steps to Reproduce:

  1. Set Zen mode as default opening mode (if the exit is also in Zen mode) in settings.json by "zenMode.restore": true
  2. Close VS Code within Zen mode by CTRL+W or CTRL+SHIFT+W
  3. Reopen VS Code, the VS Code is in full-screen mode, not the expected Zen mode.

Does this issue occur when all extensions are disabled?: Yes.

@vscodebot
Copy link

@vscodebot vscodebot bot commented Feb 27, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@bpasero bpasero assigned isidorn and unassigned bpasero Feb 28, 2018
@isidorn
Copy link
Contributor

@isidorn isidorn commented Feb 28, 2018

I can not reproduce this.
@mhxion please try with latest vscode insiders https://code.visualstudio.com/insiders/

If you can reproduce still please give us exact steps how you enter zen mode, when do you change the setting and do you explicitly enter full screen

@mhxion
Copy link
Author

@mhxion mhxion commented Mar 1, 2018

@isidorn
Does this issue also persist in the Insider version? - Yes.

Detailed Re-procedure:

vs-code-insider-zenmode-bug-001

  1. Open VS Code Insider normally. Go to settings.json
  2. Add "zenMode.restore": true to enable

a window should restore to zen mode if it was exited in zen mode

  1. Toggle to Zen mode. Close vs code within zen mode (CTRL+Q or ALT>File>Quit)
  2. Restart vs code. The vs code is not in the expected Zen mode but rather in full screen mode.

The result is the same also if everything was done by using shortcuts.

@isidorn
Copy link
Contributor

@isidorn isidorn commented Mar 1, 2018

This is a general issue that we are not storing UX state for the no folder workspace.

We are storing zen mode per workspace, which means you need to open a folder first in oreder for this to be respected..
I could also store zen mode per user storage.

@bpasero do you already have an issue to preserve state across no folder workspaces

@bpasero
Copy link
Member

@bpasero bpasero commented Mar 1, 2018

@isidorn we store UX state for empty windows too, e.g. you can have an empty window with some UI state (e.g. editor layout), quit and restart and it will be restored.

I cannot reproduce on macOS btw.

@mhxion
Copy link
Author

@mhxion mhxion commented Mar 1, 2018

@isidorn I first faced the issue while working with a folder in a workspace. But as @bpasero found, it's possible that it's just in Mint/Debian. Maybe configuring a whole new screen state same-as-zen-mode for start up could fix the issue. I'm a big fan of VS code's Zen mode even as a noob, hope this gets fixed in future. Thanks for the hard work.

@bpasero
Copy link
Member

@bpasero bpasero commented Mar 1, 2018

If this only reproduces on Linux, this could be #36964 (@Tyriar)

@isidorn
Copy link
Contributor

@isidorn isidorn commented Mar 1, 2018

Yup, @mhxion please comment on that issue as this is a duplicate. Thanks

@isidorn isidorn closed this Mar 1, 2018
@isidorn isidorn added the *duplicate label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.