-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows 7 (classic theme): Title flashes with custom menubar enabled #56630
Comments
@Thunraz are you using some custom window manager or theming program? |
@bpasero no, just regular Windows. Edit: to compare with the expected behavior, I've installed 1.25.1 again: |
@Thunraz interesting, and in 1.25 you are also using the custom title bar style right? In that case I suspect an issue with the Electron update. Can you just try with a very new version of VSCode (make sure to set title bar to custom again): https://az764295.vo.msecnd.net/exploration/57d01751b88c89046b33be3f1d55f860041fd27b/VSCode-win32-x64-1.27.0-exploration.zip |
@bpasero Yes, in 1.25 I was also using custom title bar style (I've updated my comment above with a GIF showing the expected behavior). Unfortunately, the Exploration version of VSCode shows the same behavior: I've just done another test since I'm using the "classic" Windows theme (i.e. Windows 9x/2000 window styles). When using the "modern" theme, there's no native title bar flash: |
@Thunraz yeah so it is indeed related to changing a theme in Windows 7 it seems. |
This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines. Happy Coding! |
Is there any more information I could provide? |
At this time no, I fear I have no workaround currently other than not using that windows theme. |
I have the same problem. |
@kanlukasz Thanks for workaround but in this mode 'Alt' keypress doesn't activate the menu bar. Light menu bar doesn't look good with dark themes. Vertical space is wasted. I wish it could be fixed. That's is one of the reasons I don't use VS Code. |
Unfortunately the issue persists with the exploration build. |
@sbatten moving forward you need to come up with a standalone reproducible sample and file this to Electron if we want a fix. I think leaving this issue dormant without this action we can equally just close this as wontfix. |
I'll try with Electron Fiddle in a Win7 VM. Assigned to October just for getting a repro and upstream bug. |
This seems to be related to that Win 7 basic theme uses GDI for drawing while aero theme and all later windows versions use DirectX. |
After quite a bit of playing around, the culprit is outlined in the upstream bug linked above. The good news is, there is another workaround that one can use if you don't really care about so much state in the window title. Workaround: |
Redirecting to @deepak1556 to retriage this since upstream has no traction |
Can still reproduce on my VsCode too, but the workaround fixed the issue. |
Windows 7 is no longer supported by VSCode, you can read more about it at https://code.visualstudio.com/docs/supporting/faq#_can-i-run-vs-code-on-windows-7 |
When window.titleBarStyle is set to custom there is a brief flash of the native title bar when switching between files. This behavior also happens for me in the current Insiders build, but didn't occur in v1.25.1.
Steps to Reproduce:
Does this issue occur when all extensions are disabled?: Yes
The text was updated successfully, but these errors were encountered: