Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Utilize Button for all 'Edit settings.json' link #58923

Open
cleidigh opened this issue Sep 19, 2018 · 6 comments · May be fixed by #84946
Open

Settings: Utilize Button for all 'Edit settings.json' link #58923

cleidigh opened this issue Sep 19, 2018 · 6 comments · May be fixed by #84946
Assignees
Milestone

Comments

@cleidigh
Copy link
Collaborator

@cleidigh cleidigh commented Sep 19, 2018

@roblourens

While keyboarding through the settings I think it might look better to utilize a button instead of a link.
The Link sort of dangles a bit. Additionally there are two functional issues:

  • The link gets read with the extra hyperlink baggage
  • Separately , for any of these non-typical input elements , having the User Land on a button which also uses described by will be more obvious for accessibility users.
  • For elements like 'Files Exclude' , starting on the Add button would also be a little bit more obvious than the link in the description.

image

@roblourens

This comment has been minimized.

Copy link
Member

@roblourens roblourens commented Sep 19, 2018

I think that using a button for "Edit settings.json" makes sense.

For elements like 'Files Exclude' , starting on the Add button would also be a little bit more obvious than the link in the description.

What do you mean "starting on"?

@roblourens roblourens added the bug label Sep 19, 2018
@roblourens roblourens added this to the September 2018 milestone Sep 19, 2018
@cleidigh

This comment has been minimized.

Copy link
Collaborator Author

@cleidigh cleidigh commented Sep 19, 2018

by start on I mean the first element landed on by Tab within an element setting.

For input boxes you have the first tab index on the input element and from a reader perspective we read out the element title and then the extended description which may include links.

On several of the glob settings or others, the first tab index is a link within the description so in Accessability user does not get the readout of the element title in until one or more tabs.

Starting on the applicable button would allow us to read out in the same way as the other elements.

@roblourens

This comment has been minimized.

Copy link
Member

@roblourens roblourens commented Sep 19, 2018

I think that it's important for tab order to follow the document order, I think that's what people expect.

@cleidigh

This comment has been minimized.

Copy link
Collaborator Author

@cleidigh cleidigh commented Sep 19, 2018

actually I misspoke, if an input box has a link in the description, you do 'start' there.

What do you think about the fact that the reader then reads the link but the user does not know what the element is. Would not starting on the input element with its associated labels make sense?

Otherwise we could add the element title to the links? Just a thought .

@roblourens

This comment has been minimized.

Copy link
Member

@roblourens roblourens commented Sep 19, 2018

At some point I'll look into a type of navigation that skips links and other focusable elements and just jumps between controls. I think that would be a better potential solution.

@cleidigh

This comment has been minimized.

Copy link
Collaborator Author

@cleidigh cleidigh commented Sep 19, 2018

sounds good
I can help with that whenever

@roblourens roblourens removed this from the September 2018 milestone Sep 21, 2018
@roblourens roblourens added this to the Backlog milestone Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.