Allow editor.tokenColorCustomizations inside language specific

[mikecentola]

Currently you can edit the user settings and add editor.tokenColorCustomizations to modify certain colors without creating or editing an entire theme.

However, editor.tokenColorCustomizations does not work with the scope of language-specific settings... i.e.

"[language]": {
    "editor.tokenColorCustomizations": {
    }
}

This would be a huge benefit to syntax extension developers. Currently I'm developing an extension for CNC G-Code and I'd like to add a configuration option to add typical cnc g-code editor colors. I can update the user settings directly from the extension but that involves a lot of additional coding to store any current customizations that the user may have put in there already.

[mikecentola]

Here's my first iteration of the extension:

G-Code Syntax

[mikecentola]

Was this ever added to the codebase?

[usernamehw]

Wasn't it always possible?

"editor.tokenColorCustomizations": {
	"textMateRules": [
		// JavaScript
		{
			"scope": "source.js keyword",
			"settings": {
				"foreground": "#FF0000"
			}
		},
		// TypeScript
		{
			"scope": "source.ts keyword",
			"settings": {
				"foreground": "#0000ff"
			}
		},
    ]
}

[mikecentola]

Wasn't it always possible?

"editor.tokenColorCustomizations": {
	"textMateRules": [
		// JavaScript
		{
			"scope": "source.js keyword",
			"settings": {
				"foreground": "#FF0000"
			}
		},
		// TypeScript
		{
			"scope": "source.ts keyword",
			"settings": {
				"foreground": "#0000ff"
			}
		},
    ]
}

I don't remember that being possible when I first launched the extension, but let me check into it and see if I can get it to work.

[usernamehw]

source.gcode in your case, I guess.

[CameronBieganek]

Wasn't it always possible?

"editor.tokenColorCustomizations": {
	"textMateRules": [
		// JavaScript
		{
			"scope": "source.js keyword",
			"settings": {
				"foreground": "#FF0000"
			}
		},
		// TypeScript
		{
			"scope": "source.ts keyword",
			"settings": {
				"foreground": "#0000ff"
			}
		},
    ]
}
``

It is possible to make language specific color customizations this way (by using source.ts or similar as the first scope within the TextMate scope selector). However, it would be convenient if the color customizations could be separated into the language-based settings, as described by @mikecentola.

I'm not sure how this would interact with the Developer: Generate Color Theme from Current Settings command.

[gjsjohnmurray]

However, editor.tokenColorCustomizations does not work with the scope of language-specific settings

I'd like this enhancement to cover editor.semanticTokenColorCustomizations as well.

And if we get #101418 it will become possible to define separate sets of settings for dark, light and high-contrast themes.

[dkalomoiris]

However, editor.tokenColorCustomizations does not work with the scope of language-specific settings

bump for that 😎

[ian-h-chamberlain]

In relation to semantic token customizations: I found a snippet of the language extension API documentation which shows this is actually possible, but not in the typical configuration manner in the "[language"] section of configuration.

The Semantic Highlight Guide shows that it's possible to make a selector match a language with a colon (:) and the language name, such as their example:

{
  "semanticTokenColors": {
    "variable.readonly:java": "#ff0000"
  }
}

Hopefully this helps if like me you were looking for some way to make language-specific color customizations!