Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emmet tab completion is slow in large files #70371

Closed
hassanbinsafdar opened this issue Mar 13, 2019 · 11 comments

Comments

@hassanbinsafdar
Copy link

commented Mar 13, 2019

vs code Version : 1.32.1
Mac Os : 10.14.3
Hello I got a problem after to update my vscode . before it was working perfectly. Even i disabled all my extensions. But still its giving me issues and my workflow is disturbing.

I am going to attach a gif so you can check Thanks .

Does this issue occur when all extensions are disabled?: Yes/No
Yes
ezgif com-video-to-gif

@roblourens

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

Is your CPU busy? You could open Activity Monitor to check.

@hassanbinsafdar

This comment has been minimized.

Copy link
Author

commented Mar 14, 2019

@roblourens I am going to attach cpu load no cpu is not busy
It was working perfectly 1.31 but now after to update on 1.32.1 and 1.32.2 giving me this issue
NOTE : its only happens in html files .
Thanks
Screen Shot 2019-03-14 at 11 53 52 AM

@hassanbinsafdar

This comment has been minimized.

Copy link
Author

commented Mar 14, 2019

@roblourens I created new html file and i found that this issue only occurs when html file is lengthy
but on fresh file its not happening .

@hassanbinsafdar

This comment has been minimized.

Copy link
Author

commented Mar 14, 2019

@roblourens I made new gif you will get complete idea whats happening it will be helpful to identify issue. Thanks
ezgif com-video-to-gif (1)

@octref

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

I can repro this by putting everything in view-source:https://microsoft.github.io/language-server-protocol/specification in a single html file and typing in it.

@octref octref added bug html perf and removed needs more info labels Mar 14, 2019

@octref octref added this to the March 2019 milestone Mar 14, 2019

@hassanbinsafdar

This comment has been minimized.

Copy link
Author

commented Mar 21, 2019

@octref why this is not resolved yet when it will be resolved still not resolved in insiders as well

@octref

This comment has been minimized.

Copy link
Member

commented Jul 29, 2019

Verifier: Test that emmet works as expected in various embedded languages in HTML, such as css/js (suggestion in css, no suggestion in js).

Test in large documents, such as the source of https://microsoft.github.io/language-server-protocol/specification, emmet completion is reasonably fast (compare with stable).

@hassanbinsafdar

This comment has been minimized.

Copy link
Author

commented Jul 30, 2019

@octref Yes in css its working completely fine but in html large file not working same issue as i showed you if you want i can make gif , vs code version and will show you issue. Thanks

@hassanbinsafdar

This comment has been minimized.

Copy link
Author

commented Jul 30, 2019

Here is my gif vs code version 1.36.1 My html file has 4992 lines of code.
vscode

@octref

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

The change is not in Insiders yet, wait a bit.

@octref octref changed the title html suggestions and tab completion slow in latest stable release emmet tab completion slow in latest stable release Jul 30, 2019

@octref octref changed the title emmet tab completion slow in latest stable release emmet tab completion is slow Jul 30, 2019

@octref octref added emmet and removed html labels Jul 30, 2019

@octref

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

Fixed by #78207.

@octref octref closed this Jul 30, 2019

octref added a commit that referenced this issue Jul 30, 2019

@roblourens roblourens added the verified label Jul 31, 2019

@octref octref changed the title emmet tab completion is slow emmet tab completion is slow in large files Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.