Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse back and forward buttons do not work on linux/windows anymore #71318

Closed
Yanpas opened this issue Mar 27, 2019 · 24 comments

Comments

@Yanpas
Copy link
Contributor

commented Mar 27, 2019

Issue Type: Bug

They work in chrome and worked in vs code before. But in 1.32 they don't work anymore. Can't remember exact version where they worked but in chromium these buttons work fine. These buttons are recognized by X as 8 and 9.

VS Code version: Code 1.32.3 (a3db5be, 2019-03-14T23:38:49.842Z)
OS version: Linux x64 4.19.31-1-lts

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz (8 x 2471)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: disabled_software
surface_synchronization: enabled_on
video_decode: unavailable_off
webgl: enabled
webgl2: enabled
Load (avg) 1, 1, 2
Memory (System) 15.61GB (4.96GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (47)
Extension Author (truncated) Version
better-comments aar 2.0.3
vscode-hie-server ala 0.0.25
better-toml bun 0.3.2
path-intellisense chr 1.4.2
vscode-eslint dba 1.8.2
vscode-dash dee 2.1.0
xml Dot 2.4.0
gitlens eam 9.5.1
EditorConfig Edi 0.13.0
prettier-vscode esb 1.8.1
file-icons fil 1.0.16
code-runner for 0.9.7
kotlin fwc 0.1.13
godot-tools gee 0.3.7
todo-tree Gru 0.0.125
live-html-previewer hdg 0.3.0
hoogle-vscode jca 0.0.7
svn-scm joh 1.47.10
language-haskell jus 2.5.0
favorites kdc 2.4.5
Lisp mat 0.1.8
vscode-todo-parser min 1.9.1
vscode-language-pack-ru MS- 1.32.4
python ms- 2019.3.6139
cpptools ms- 0.22.1
csharp ms- 1.18.0
mono-debug ms- 0.15.8
vscode-typescript-tslint-plugin ms- 1.0.0
vsliveshare ms- 0.3.1403
debugger-for-chrome msj 4.11.3
gradle-language nac 0.2.3
vscode-subword-navigation ow 1.2.0
phoityne-vscode pho 0.0.22
java red 0.41.0
vscode-yaml red 0.4.0
rust rus 0.5.4
vscode-hexdump sle 1.7.2
emmylua tan 0.2.3
cmake twx 0.0.17
cmake-tools vec 1.1.3
vscodeintellicode Vis 1.1.5
vscode-svg-previewer vit 0.5.0
vscode-java-debug vsc 0.17.0
debug web 0.23.0
jinja who 0.0.8
clang-format xav 1.9.0
vscode-proto3 zxh 0.2.2
@Tyriar

This comment has been minimized.

Copy link
Member

commented Mar 31, 2019

What did they used to do?

@Yanpas

This comment has been minimized.

Copy link
Contributor Author

commented Mar 31, 2019

If I ctrl+clicked on some word in code (go to definition) and clicked back button I would return to my previous cursor position.

I think that they were bound to workbench.action.navigateBack, workbench.action.navigateForward actions.

@look-at-me

This comment has been minimized.

Copy link

commented Jun 15, 2019

Same issue on Windows now. This works in the latest released VS Code 1.35.1 on Windows, but it doesn't on insiders:

Version: 1.36.0-insider (system setup)
Commit: 15b7c86d86319b187a5ef255c170184a8519c5af
Date: 2019-06-14T10:37:04.235Z
Electron: 4.2.4
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18362
@stssk

This comment has been minimized.

Copy link

commented Jun 17, 2019

Same issue on windows: Mouse back and mouse forward does not navigate

Version: 1.36.0-insider (user setup)
Commit: 11b88a3
Date: 2019-06-17T05:17:47.485Z
Electron: 4.2.4
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.16299

@aruproy14

This comment has been minimized.

Copy link

commented Jun 19, 2019

+1 for hitting this issue on latest code insider on Windows.

Version: 1.36.0-insider (user setup)
Commit: d04b5d2
Date: 2019-06-13T05:19:34.516Z
Electron: 4.2.3
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18915

@furier

This comment has been minimized.

Copy link

commented Jul 2, 2019

same, and it makes me go insane!

Version: 1.36.0-insider (user setup)
Commit: fe0c3e785c22c3ed2d5caa7178488c92d62bdb08
Date: 2019-06-28T12:34:35.956Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18362
@bkromhout

This comment has been minimized.

Copy link

commented Jul 3, 2019

As others have noted, this bug clearly isn't limited to Linux, navigating back/forward via mouse buttons broke when I updated from 1.35.1 to 1.36.0 (stable) today.

Version: 1.36.0 (system setup)
Commit: 0f3794b38477eea13fb47fbe15a42798e6129338
Date: 2019-07-03T13:25:46.372Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.17763
@bpasero

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

electron/electron#17134 seems to be the origin of this issue.

@bpasero

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

I have pushed a change to not rely on Electron for these mouse events and rather listen on the MouseEvent.button values 3 and 4. This can also be turned off now with the new setting workbench.editor.mouseBackForwardToNavigate

NOTE: we NEVER supported mouse navigation on Linux. The solution we had in place was ONLY working on Windows. With my new changes however I can see it working for Linux as well as Windows, however not macOS. There you can configure the workbench.editor.swipeToNavigate setting to navigate via swipe gesture.

@bkromhout

This comment has been minimized.

Copy link

commented Jul 4, 2019

Thanks for the quick work @bpasero! Is there any possibility we might be able to get this into the June 2019 Recovery milestone rather than the July 2019 milestone? Having to wait a month for a high-use (and very intuitive, muscle-memory wise) navigation feature like this would be rather painful.

@bpasero bpasero added the candidate label Jul 4, 2019

@bpasero bpasero modified the milestones: July 2019, June 2019 Recovery Jul 4, 2019

@bpasero bpasero reopened this Jul 4, 2019

@bpasero

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

Reopening for discussion for recovery.

bpasero added a commit that referenced this issue Jul 4, 2019

@bpasero bpasero changed the title Mouse back and forward buttons do not work on linux anymore Mouse back and forward buttons do not work on linux/windows anymore Jul 4, 2019

@bpasero

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

It would be nice if people could validate the fix on Windows and Linux from our latest (just released) insider build: https://code.visualstudio.com/insiders/

@look-at-me

This comment has been minimized.

Copy link

commented Jul 5, 2019

Still not working for me.

Version: 1.36.0-insider (system setup)
Commit: 0f3794b
Date: 2019-07-03T08:00:29.662Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18362

@bpasero

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

@look-at-me due to a lot of build issues we had to roll back our insiders build and it does not seem to include my fix.

Here are builds to try it out:

@roger225

This comment has been minimized.

Copy link

commented Jul 5, 2019

@look-at-me due to a lot of build issues we had to roll back our insiders build and it does not seem to include my fix.

Here are builds to try it out:

It's working

@furier

This comment has been minimized.

Copy link

commented Jul 5, 2019

@look-at-me due to a lot of build issues we had to roll back our insiders build and it does not seem to include my fix.

Here are builds to try it out:

works for me as well! :)

bpasero added a commit that referenced this issue Jul 5, 2019

@bpasero

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

This will be released next week as a recovery fix to stable. Thanks for testing 👍

@bpasero bpasero closed this Jul 5, 2019

@lanovoy

This comment has been minimized.

Copy link

commented Jul 5, 2019

Can we get a hotfix for it into 1.36? Extremely annoying issue making VSCode for me borderline unusable...

@N3bul0

This comment has been minimized.

Copy link

commented Jul 5, 2019

Pretty annoying, I am so used to it! Thanks for your fast response in fixing and releasing that!

A dirty workaround: Bind your back and forward keys to "Alt + LeftArrow/RightArrow".

@bradgearon

This comment has been minimized.

Copy link

commented Jul 6, 2019

1.37.0-insider seems to work

@MrMuMu

This comment has been minimized.

Copy link

commented Jul 10, 2019

It seems to work however with a change of behaviour:

It was navigating forward/backward based on history of the cursor position, but it is now navigating based on files.

@lanovoy

This comment has been minimized.

Copy link

commented Jul 10, 2019

So far the best 'workaround' is downgrading to 1.35 (download it here https://code.visualstudio.com/updates/v1_35 )

@inliquid

This comment has been minimized.

Copy link

commented Jul 10, 2019

For me on Windows machine it navigates based on cursor position. Not very precisely, tbh, it misses some intermediary positions, however it works same as when pressing Alt-Fwd/Back

@furier

This comment has been minimized.

Copy link

commented Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.