Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleteFile keyboard shortcut adds the word 'Delete' to the explorer #76514

Closed
DanielSharp01 opened this issue Jul 3, 2019 · 19 comments

Comments

@DanielSharp01
Copy link

commented Jul 3, 2019

Issue Type: Bug

So far when delete was pressed it deleted the file in the explorer, not it just adds the word Delete in capital letters to the file search,

VS Code version: Code - Insiders 1.36.0-insider (b7ca272, 2019-07-02T12:07:21.186Z)
OS version: Linux x64 4.18.0-25-generic snap

@DanielSharp01 DanielSharp01 changed the title `deleteFile` keyboard shortcut adds the word delete to the explorer `deleteFile` keyboard shortcut adds the word Delete to the explorer Jul 3, 2019

@DanielSharp01 DanielSharp01 changed the title `deleteFile` keyboard shortcut adds the word Delete to the explorer deleteFile keyboard shortcut adds the word 'Delete' to the explorer Jul 3, 2019

@isidorn

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

Can you please post a video showing this?
You can F1 > toggle screen cast mode and then record so we see what keys get pressed?

I do not have a keyboard with the delete key thus I can not test this atm
Do you have some custom keybdinings?

@DanielSharp01

This comment has been minimized.

Copy link
Author

commented Jul 3, 2019

I do not have any custom key bindings. I'll post a video later about the issue.

@isidorn

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

Thanks

@renanhangai

This comment has been minimized.

Copy link

commented Jul 3, 2019

It happened to me as well

Version: 1.36.0
Commit: 0f3794b
OS: Linux x64 4.15.0-54-generic

Delete

@tkvw

This comment has been minimized.

Copy link

commented Jul 3, 2019

Same issue here:

Version: 1.36.0
Commit: 0f3794b38477eea13fb47fbe15a42798e6129338
Date: 2019-07-03T13:20:56.241Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Linux x64 4.15.0-54-generic
@sabariramc

This comment has been minimized.

Copy link

commented Jul 4, 2019

Same issue

Version: 1.36.0
Commit: 0f3794b38477eea13fb47fbe15a42798e6129338
Date: 2019-07-03T13:20:56.241Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Linux x64 5.0.0-15-generic
@isidorn

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

@joaomoreno the tree seems to be eating up the Delete key. I can not repro on win. But I can repro on Linux. This is a recent change in the past week.
It seems like something changed in the last release, since users did not hit this before.
Did we change something in how the tree handles the delete key?

Adding candidate since this is a regression.

@joaomoreno

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

@jrieken Ooops.

@joaomoreno joaomoreno added this to the June 2019 Recovery milestone Jul 4, 2019

@isidorn isidorn removed their assignment Jul 4, 2019

@joaomoreno

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

Yep, definitely reproducible.

Broken by 382e1a0, related to #74934

Workaround: use the context menu for now.

@jrieken

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

We have logic to know whether a key press results in a printable character or not, e.g on most keyboard KEY_F prints f, SHIFT+KEY_F prints F, ESC prints nothing etc. To know if the tree should start filtering or not we run this logic and it seems broken on linux, thinking that KEY_Delete prints delete, e.g. in a text field.

@jrieken

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

Talked to @alexandrudima, seems we have some utils for this:

export const IMMUTABLE_CODE_TO_KEY_CODE: KeyCode[] = [];

@Manviel

This comment was marked as spam.

Copy link

commented Jul 4, 2019

Same issue!

@ilyarudnitsky

This comment was marked as spam.

Copy link

commented Jul 4, 2019

Same issue!

Fix please!

@joaomoreno joaomoreno closed this in 64162b6 Jul 4, 2019

joaomoreno added a commit that referenced this issue Jul 4, 2019

@srfrnk

This comment has been minimized.

Copy link

commented Jul 5, 2019

Seems like this should've been fixed in 1.36.0 am I wrong?

If so - still happens to me:

Version: 1.36.0
Commit: 0f3794b38477eea13fb47fbe15a42798e6129338
Date: 2019-07-03T13:20:56.241Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Linux x64 4.15.0-54-generic
@jurosh

This comment has been minimized.

Copy link

commented Jul 5, 2019

@srfrnk it was reported for 1.36.0, so fix will likely be included in the next minor release. https://github.com/microsoft/vscode/milestone/99

@srfrnk

This comment has been minimized.

Copy link

commented Jul 5, 2019

@jurosh Thanks for the info.
I thought since commit 76608 was merged into release 1.36 - this meant it was included in 1.36.
My bad.

@mirao

This comment has been minimized.

Copy link

commented Jul 5, 2019

Another workaround: Disable the setting workbench.list.automaticKeyboardNavigation

@srfrnk

This comment has been minimized.

Copy link

commented Jul 6, 2019

Another workaround: Disable the setting workbench.list.automaticKeyboardNavigation

Thx @mirao - that helps!

@frederikheld

This comment has been minimized.

Copy link

commented Jul 9, 2019

You are awesome folks! I had this issue with 1.36 only on Ubuntu, not on Windows. But both hat exactly the same settings for key bindings. It drove me nuts :-P Thank you so much for fixing and deploying it so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.