Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode.env.openExternal is not working correctly because of unnecessary escape processing. #76606

Closed
wraith13 opened this issue Jul 4, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@wraith13
Copy link

commented Jul 4, 2019

  • VSCode Version: v1.36 and 1.36.0-insider
  • OS Version: Windows, Mac

Steps to Reproduce:

Just excute this code in a extention.

vscode.env.openExternal(vscode.Uri.parse("x-github-client://openRepo/https://github.com/wraith13/open-in-github-desktop-vscode.git"));

x-github-client is a GitHub Desktop's protocol.
GitHub Desktop receives openRepo/https%3A//github.com/wraith13/open-in-github-desktop-vscode.git and fail. ( Must be openRepo/https://github.com/wraith13/open-in-github-desktop-vscode.git )

Does this issue occur when all extensions are disabled?: No ( It is API for extensions )

It worked fine with v1.35.
I think that it may be a problem of electron.

@jrieken

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

This is a regression from 781e61b (which itself fixes a regression from #73849). Next try...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.