Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.36 broke custom Tasks to run on split terminal if no terminal is active #76611

Closed
felipe-spengler-osf opened this issue Jul 4, 2019 · 6 comments

Comments

Projects
None yet
4 participants
@felipe-spengler-osf
Copy link

commented Jul 4, 2019

Hi

I have been using a custom task to group some tasks that I run daily on a split terminal. This was possible since version 1.31.1 introduced the "group" attribute on presentation.

Update: I usually kill any terminal before running this, and today with update 1.36 this stopped working, tasks run on dedicated terminal and VSCode shows a tooltip with "No enough space to split terminal" (which is totally nonsense as I have a 2560px display), and when I kill the terminals an error "Should never try to resolve undefined" appears and also on DevTools.

If I already have a terminal open and run my custom Task, then it works fine as before!

This is my tasks config:

{
    // See https://go.microsoft.com/fwlink/?LinkId=733558 
    // for the documentation about the tasks.json format
    "version": "2.0.0",
    "tasks": [
        {
            "label": "DW Utils Watch",
            "type": "shell",
            "command": "dw-utils watch",
            "problemMatcher": [],
            "presentation": {
                "echo": true,
                "reveal": "always",
                "focus": false,
                "panel": "dedicated",
                "showReuseMessage": true,
                "clear": false,
                "group": "GroupA"
            }
        },
        {
            "label": "Watch-Vue",
            "type": "shell",
            "command": "gulp watch2",
            "problemMatcher": [],
            "presentation": {
                "echo": true,
                "reveal": "always",
                "focus": false,
                "panel": "dedicated",
                "showReuseMessage": true,
                "clear": false,
                "group": "GroupA"
            }
        },
        {
            "label": "Watchers",
            "type": "shell",
            "problemMatcher": [],
            "dependsOn": [
                "DW Utils Watch",
                "Watch-Vue"
            ]
        }
    ]
}
  • VSCode Version: 1.36.0 (user setup)
  • OS: Windows_NT x64 10.0.18362

Does this issue occur when all extensions are disabled?:
Yes

Any ideas??

Thanks

@vscodebot

This comment has been minimized.

Copy link

commented Jul 4, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the new release label Jul 4, 2019

@felipe-spengler-osf felipe-spengler-osf changed the title 1.36 broke custom Tasks to run on split terminal 1.36 broke custom Tasks to run on split terminal if no terminal is active Jul 4, 2019

@alexr00

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

@Tyriar this appears to be a timing issue. At the time that tasks gets the terminal instance, it hasn't actually been finished being created yet.

@alexr00 alexr00 added the candidate label Jul 5, 2019

@alexr00

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

The "Should never try to resolve undefined" is unrelated to the split terminal, but should also be fixed.

@alexr00

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

@Tyriar it's a little hacky, but as a simple fix for the terminal splitting I can waitForTitle on the first terminal. It seems that be the time it has a title it also has a height and width.

@alexr00 alexr00 added this to the June 2019 Recovery milestone Jul 5, 2019

pull bot pushed a commit to Jared-Dev/vscode that referenced this issue Jul 5, 2019

alexr00 added a commit that referenced this issue Jul 5, 2019

alexr00 added a commit that referenced this issue Jul 5, 2019

alexr00 added a commit that referenced this issue Jul 5, 2019

alexr00 added a commit that referenced this issue Jul 5, 2019

alexr00 added a commit that referenced this issue Jul 5, 2019

Fix commandless tasks (#76689)
* Fix commandless tasks

Part of #76611

* Fix for custom tasks

@alexr00 alexr00 closed this Jul 8, 2019

@alexr00

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

To verify kill all your integrated terminals then run task three:

        {
            "label": "one",
            "command": "sleep 11",
            "type": "shell",
            "problemMatcher": [],
            "presentation": {
                "group": "one"
            }
        },
        {
            "label": "two",
            "command": "sleep 12",
            "type": "shell",
            "problemMatcher": [],
            "presentation": {
                "group": "one"
            }
        },
        {
            "label": "three",
            "type": "shell",
            "problemMatcher": [],
            "dependsOn": [
                "one",
                "two"
            ]
        },

Verify that you see tasks one and two in split terminals next to each other and that there are no task related errors in the console.

@jrieken jrieken added the verified label Jul 9, 2019

@bpasero

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Verified on Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.