Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[json] confusing error message when schema can not be loaded #76633

Closed
SetTrend opened this issue Jul 4, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@SetTrend
Copy link

commented Jul 4, 2019

After having updated to the latest VS Code version (1.36.0) on a machine with no Internet access a few moments ago I noticed that VS Code is now regularly throwing JSON exceptions.

image

@aeschli aeschli added this to the June 2019 Recovery milestone Jul 8, 2019

@aeschli aeschli added the candidate label Jul 8, 2019

@aeschli

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

It's not really crashing, just a confusing message when a schema can not be loaded.
@SetTrend Can you confirm? Or do you really see the JSON server crash?

@aeschli aeschli changed the title JSON service crashes regularly [json] confusing error message when schema can not be loaded Jul 8, 2019

@octref

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Would be fixed by #76905, but we need to verify.

@octref octref closed this Jul 8, 2019

@aeschli

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

To verify:

create a JSON:

{
	"$schema": "https://schema"
}

Verify that the error no longer mentions 'vscode/content unexpectedly failed`

Depending on the site, the 404 errors could still be improved, but this was the minimal fix to what we had before.

@jrieken

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Seeing a ENOTFOUND error now, adding verified-label

Screenshot 2019-07-09 at 10 39 04

@jrieken jrieken added the verified label Jul 9, 2019

@SetTrend

This comment has been minimized.

Copy link
Author

commented Jul 11, 2019

@aeschli , @jrieken 👍

Here's another confusing error presented when no Internet connection is available:

JSON schema could not be loaded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.