Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Fix hover not working #76851

Closed
archer3cl opened this issue Jul 5, 2019 · 12 comments

Comments

Projects
None yet
10 participants
@archer3cl
Copy link

commented Jul 5, 2019

After updating to VS Code 1.36.0 the option for quick fix when hovering does not apply the related action.
NOACTION

Using the quick fix on the bulb action does.
ACTION

VS Code Info
Version: 1.36.0 (user setup)
Commit: 0f3794b
Date: 2019-07-03T13:25:46.372Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18362

@MatiasOlivera

This comment has been minimized.

Copy link

commented Jul 5, 2019

I'm having the same problem after updating VSCode to 1.36. I'm going to use the bulb action meanwhile.

@zjb19970804

This comment has been minimized.

Copy link

commented Jul 6, 2019

Yes, after updating the latest version of vscode IDE today, eslint plugin has not work. It used to be normal, but I can use Ctrl +. to fix code errors.

@dbaeumer

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

@mjbvz same as with the Java plugin. Has something changed here in VS Code ?

@dbaeumer

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

I move the issue to VS Code since the quick fix action computation is the same in both pathes.

@dbaeumer dbaeumer transferred this issue from microsoft/vscode-eslint Jul 8, 2019

@mjbvz mjbvz assigned sandy081 and unassigned mjbvz Jul 8, 2019

@mjbvz mjbvz self-assigned this Jul 8, 2019

@mjbvz

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

Doesn't happen for JS/TS in my testing. Will try with eslint and java

@mjbvz

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

Simple example for eslint. Only happens sometimes:

// @ts-check
import * as React from 'react';

export default <div dangerouslySetInnerHTML={{ __html: '' }} />
@mjbvz

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

Repo

  1. Install eslint and create basic config file.
  2. In a file:
// @ts-check
import * as React from 'react';

export default <div dangerouslySetInnerHTML={{ __html: '' }} />
  1. Wait for warning to show up on dangerouslySetInnerHTML.
  2. Place cursor before dangerouslySetInnerHTML and quicky type space, delete, ctrl+. to trigger code actions
  3. Select one of the suppress fixes

Bug
Code action not applied

@mjbvz mjbvz closed this in 7ef96fc Jul 8, 2019

mjbvz added a commit to mjbvz/vscode that referenced this issue Jul 8, 2019

Fix lifecycle for code actions that are updated while the code action…
… menu is already showing

Fixes microsoft#76851

In the following case

1. Code action list is shown
1. We then update the code actions in the background (possibly because extensions took a little while to compute them)
1. The user accepts a code action

At step 2, we release the previous code action list which causes all of its actions to be gabage collected

**Fix**
Move lifecycle management of the code actions into the two consumers. Will look into make the code safer with a follow up fix
@infinnie

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

I'm having the same problem after updating VSCode to 1.36. I'm going to use the bulb action meanwhile.

But it is hard for bulbs to pop up sometimes.

@Fernandomr88

This comment has been minimized.

Copy link

commented Jul 9, 2019

Still not working on DART/Flutter

@infinnie

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

This doesn’t seem to have been fixed in the 1.36.1 update.

@Fernandomr88

This comment has been minimized.

Copy link

commented Jul 10, 2019

This doesn’t seem to have been fixed in the 1.36.1 update.

Already reported here #77018

@babs232

This comment has been minimized.

Copy link

commented Jul 11, 2019

Below is what I am getting as error while using Quick Action:

[2019-07-11 10:38:38.078] [exthost] [warning] redhat.java - Code actions of kind 'quickfix 'requested but returned code action is of kind 'source.generate.delegateMethods'. Code action will be dropped. Please check 'CodeActionContext.only' to only return requested code actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.