Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug integrated terminal support doesn't get default terminal #77110

Closed
Tyriar opened this issue Jul 10, 2019 · 1 comment

Comments

@Tyriar
Copy link
Member

commented Jul 10, 2019

This is now null by default

const shell_config = config.integrated.shell;
, so the debugger will be often falling back to the system shell instead of the terminal's actual default.

You can call into ITerminalInstanceService.getDefaultShellAndArgs (or getDefaultShell in terminalEnvironment.ts) to get a string now so you don't need to fallback to getSystemShell.

@Tyriar

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

Verified by making sure variable resolution worked when debugging in integrated terminal "terminal.integrated.shell.linux": "${env:SHELL}"

@Tyriar Tyriar added the verified label Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.