Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce cursor word accessibilty commands #79712

Merged
merged 5 commits into from Aug 26, 2019
Merged

Conversation

isidorn
Copy link
Contributor

@isidorn isidorn commented Aug 23, 2019

This is still work in progress (exact implementation in the WordOperations has to be fixed and the tests need to be updated). I have to go now, but plan to tackl next week.

This PR introduces the following commands:

  • cursorWordAccessibilityLeft
  • cursorWordAccessibilityLeftSelect
  • cursorWordAccessibilityRight
  • cursorWordAccessibilityRightSelect

When we are in the accessibility mode this commands get keybaord shorctus ctrl/cmd + left / right.
Thus taking precendence of the regular navigation commands.

The idea of this commands is to have word navigation behave like the word navigation of Chrome thus fixing #28306

fyi @alexandrudima

@isidorn isidorn added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Aug 23, 2019
@isidorn isidorn added this to the August 2019 milestone Aug 23, 2019
@isidorn isidorn self-assigned this Aug 23, 2019
@isidorn isidorn merged commit c8c773a into master Aug 26, 2019
@isidorn isidorn deleted the isidorn/cursorAccessibility branch August 26, 2019 21:34
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant