Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chords to "show same keybindings" #80181

Open
jabacchetta opened this issue Sep 1, 2019 · 3 comments
Open

Add chords to "show same keybindings" #80181

jabacchetta opened this issue Sep 1, 2019 · 3 comments

Comments

@jabacchetta
Copy link

@jabacchetta jabacchetta commented Sep 1, 2019

Currently, to find conflicts caused by a chord, you need to search for the first sequence, without any quotes. This works, but since the search is global across all four columns of information for each keyboard rule, it brings up a variety of commands that you're not interested in. Additionally, it's probably not an obvious way to find conflicts for most VSCode users.

I wonder if "Show Same Keybindings" should not only show the exact same keybindings, but also any keybindings where the first sequence of a chord matches. Alternatively, there could be a second option added to the context menu that does this.

@vscodebot
Copy link

@vscodebot vscodebot bot commented Sep 1, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@sandy081
Copy link
Member

@sandy081 sandy081 commented Sep 2, 2019

I like the idea of having separate entry/mechanism to look for keybindings containing keys.

@sandy081 sandy081 added this to the Backlog milestone Sep 2, 2019
@sandy081 sandy081 added the help wanted label Sep 2, 2019
@jabacchetta
Copy link
Author

@jabacchetta jabacchetta commented Sep 2, 2019

@sandy081 Similarly, when editing a keybinding through the keybinding edit widget, when it warns you with "x existing commands have this keybinding", it should probably also warn you if that keybinding is not a chord, but it appears in an existing chord sequence, which again, has the potential for conflicts.

With the two options being that those chord conflicts are either added to the existing warning count, or an additional warning is added with its own count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.