Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Search Bar function doesn't refocus by current definition in the settings editor #83623

Closed
smilegodly opened this issue Oct 30, 2019 · 1 comment · Fixed by #83617
Closed
Assignees
Labels
Milestone

Comments

@smilegodly
Copy link
Contributor

@smilegodly smilegodly commented Oct 30, 2019

Currently the 'focusSearch' method is called directly after the 'clearSearchResults' method returns. I think they should be called in one function as they get called one after another anyways and effect the same widget.

  • I propose to add the 'focus search' method to the code below..
	clearSearchResults(): void {
		this.searchWidget.setValue('');
	}

Also.. there's an extra 'clear search' function in the settings editor that can be replaced by this code.

@vscodebot

This comment has been minimized.

Copy link

@vscodebot vscodebot bot commented Oct 30, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@smilegodly smilegodly changed the title Clear Search Bar function doesn't refocus by current definition Clear Search Bar function doesn't refocus by current definition in the settings editor Oct 30, 2019
@mjbvz mjbvz assigned rebornix and roblourens and unassigned rebornix Oct 30, 2019
@roblourens roblourens added this to the November 2019 milestone Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.