Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add CTRL+SHIFT+* Support in Terminal #84080

Closed
tracker1 opened this issue Nov 6, 2019 · 7 comments · Fixed by #84438
Closed

Feature: Add CTRL+SHIFT+* Support in Terminal #84080

tracker1 opened this issue Nov 6, 2019 · 7 comments · Fixed by #84438

Comments

@tracker1
Copy link

@tracker1 tracker1 commented Nov 6, 2019

Much like the new Windows Terminal, and various terminal applications on other OSes, it would be nice of the terminal panel in VS Code supported CTRL+SHIFT+*, such as CTRL+SHIFT+C for copy and CTRL+SHIFT+V for paste.

This is pretty much built into muscle memory and it's annoying on windows in VS Code (I think it already works this way at least in Linux) when the behavior is different and/or unsupported.

@tracker1 tracker1 changed the title Feature: Add CTRL+SHIFT+* Support Feature: Add CTRL+SHIFT+* Support in Terminal Nov 6, 2019
@Tyriar

This comment has been minimized.

Copy link
Member

@Tyriar Tyriar commented Nov 7, 2019

@Tyriar Tyriar added this to the Backlog Candidates milestone Nov 7, 2019
@Tyriar Tyriar removed their assignment Nov 7, 2019
@Grommers00

This comment has been minimized.

Copy link
Contributor

@Grommers00 Grommers00 commented Nov 7, 2019

Could I try tackling this?

@tracker1

This comment has been minimized.

Copy link
Author

@tracker1 tracker1 commented Nov 8, 2019

@Tyriar thanks, had to add a keybindings.json file to %APPDATA%/Code

@Grommers00 hopefully your PR is accepted, would be nice if the defaults supported both... for me muscle memory has gotten pretty strong.. I tend to split my time pretty evenly on Windows and Linux lately, though less time on Mac since I switched to Linux at home, and will probably swap out my Macbook later in the year.

@tracker1

This comment has been minimized.

Copy link
Author

@tracker1 tracker1 commented Nov 8, 2019

Also, it is the default in the new windows terminal itself, so would be nice to support it.. may even want to align the default with a big release note.

@Tyriar Tyriar modified the milestones: Backlog Candidates, Backlog Nov 8, 2019
@Tyriar Tyriar self-assigned this Nov 8, 2019
@Tyriar Tyriar added the help wanted label Nov 8, 2019
@Tyriar

This comment has been minimized.

Copy link
Member

@Tyriar Tyriar commented Nov 8, 2019

@Grommers00 sure, let's align since Windows Terminal does it. It should be fairly easy to do, here's the code pointer:

actionRegistry.registerWorkbenchAction(new SyncActionDescriptor(CopyTerminalSelectionAction, CopyTerminalSelectionAction.ID, CopyTerminalSelectionAction.LABEL, {
primary: KeyMod.CtrlCmd | KeyCode.KEY_C,
linux: { primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.KEY_C }
}, ContextKeyExpr.and(KEYBINDING_CONTEXT_TERMINAL_TEXT_SELECTED, KEYBINDING_CONTEXT_TERMINAL_FOCUS)), 'Terminal: Copy Selection', category);
}
if (BrowserFeatures.clipboard.readText) {
actionRegistry.registerWorkbenchAction(new SyncActionDescriptor(TerminalPasteAction, TerminalPasteAction.ID, TerminalPasteAction.LABEL, {
primary: KeyMod.CtrlCmd | KeyCode.KEY_V,
linux: { primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.KEY_V }
}, KEYBINDING_CONTEXT_TERMINAL_FOCUS), 'Terminal: Paste into Active Terminal', category);

@Grommers00

This comment has been minimized.

Copy link
Contributor

@Grommers00 Grommers00 commented Nov 8, 2019

Awesome thanks! I'll be trying it out this weekend!

@Tyriar thanks for pointing me in the right direction :).

@Grommers00

This comment has been minimized.

Copy link
Contributor

@Grommers00 Grommers00 commented Nov 11, 2019

I believe this is good, the comment line above also had a spelling mistake, miht instead of might. So I included that as well. Also, I tested and seemed to work well.

Let me know if this is good or if I need to make additional changes.

@Tyriar Tyriar modified the milestones: Backlog, November 2019 Nov 17, 2019
Tyriar added a commit that referenced this issue Nov 17, 2019
fix #84080 added cntl-shift-c and cntl-shift-v to terminal
@connor4312 connor4312 added the verified label Dec 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.