Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom editors in the workbench #84672

Open
bpasero opened this issue Nov 13, 2019 · 4 comments
Open

Support for custom editors in the workbench #84672

bpasero opened this issue Nov 13, 2019 · 4 comments
Assignees
Labels
Milestone

Comments

@bpasero
Copy link
Member

@bpasero bpasero commented Nov 13, 2019

To support custom editors (#77131, #12176) we need our IWorkingCopyService to become more powerful, specifically taking over responsibility of:

Work Areas:

  • dirty tracking
  • save/revert
  • auto save
  • 馃弮 hot exit
  • structural changes (move, delete, create, copy)
  • save participants (text file based only, we do not plan for an API for other extensions to modify the custom editor data)
@bpasero bpasero added the debt label Nov 13, 2019
@bpasero bpasero added this to the November 2019 milestone Nov 13, 2019
@bpasero bpasero self-assigned this Nov 13, 2019
bpasero added a commit that referenced this issue Nov 13, 2019
bpasero added a commit that referenced this issue Nov 13, 2019
bpasero added a commit that referenced this issue Nov 15, 2019
bpasero added a commit that referenced this issue Nov 17, 2019
@bpasero bpasero changed the title Implement and adopt working copy service Support for custom editors in the workbench Nov 17, 2019
@bpasero

This comment has been minimized.

Copy link
Member Author

@bpasero bpasero commented Nov 18, 2019

I think we settled on saving everything, even working copies from custom editors.

@DonJayamanne

This comment has been minimized.

Copy link
Contributor

@DonJayamanne DonJayamanne commented Nov 20, 2019

@bpasero @mjbvz Is the plan to (try) ship the custom editor in the next release?
I'd like to ensure we (Python Extension) uses this when its available.

@mjbvz

This comment has been minimized.

Copy link
Contributor

@mjbvz mjbvz commented Nov 20, 2019

No. It will remain as proposed api in 1.41

bpasero added a commit that referenced this issue Nov 21, 2019
@bpasero bpasero modified the milestones: November 2019, December 2019 Dec 5, 2019
@bpasero bpasero added plan-item and removed debt labels Dec 5, 2019
bpasero added a commit that referenced this issue Jan 10, 2020
@bpasero

This comment has been minimized.

Copy link
Member Author

@bpasero bpasero commented Jan 10, 2020

All editor auto save functionality will now work for custom editors as well.

bpasero added a commit that referenced this issue Jan 12, 2020
bpasero added a commit that referenced this issue Jan 14, 2020
@bpasero bpasero modified the milestones: January 2020, February 2020 Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.