Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcut key presses gets emitted to Webview #85879

Open
PEZ opened this issue Dec 1, 2019 · 1 comment
Open

Keyboard shortcut key presses gets emitted to Webview #85879

PEZ opened this issue Dec 1, 2019 · 1 comment
Assignees
Labels

Comments

@PEZ
Copy link

@PEZ PEZ commented Dec 1, 2019

Issue Type: Bug

When using shortcuts, while having a webview open, the shortcut's key presses ”leaks” out and are sent to the webview.

Reproduce

This can be reproduced using the Jupyter extension:

  1. Configure Zoom in to be just a character, say z, using the regular Shortcuts UI
  2. Create a new Jupyter Notebook and focus an input prompt.
  3. Use that shortcut

Expected:
VS Code zooms, and nothing else happens.

Actual:
VS Code zooms, and z is typed at the Jupyter prompt.

VS Code version: Code 1.40.2 (f359dd6, 2019-11-25T14:52:45.129Z)
OS version: Darwin x64 19.0.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2600)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) 3, 3, 3
Memory (System) 16.00GB (0.32GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (10)
Extension Author (truncated) Version
calva bet 2.0.63
emojisense bie 0.5.3
clj-kondo bor 0.0.11
better-toml bun 0.3.2
gitlens eam 10.2.0
restructuredtext lex 116.0.0
python ms- 2019.11.50794
vscode-yaml red 0.6.1
code-spell-checker str 1.7.20
JavaScriptSnippets xab 1.7.2
@PEZ PEZ changed the title The second chord of a shortcut gets emitted to Webview Keyboard shortcut key presses gets emitted to Webview Dec 1, 2019
@PEZ

This comment has been minimized.

Copy link
Author

@PEZ PEZ commented Dec 1, 2019

I am an extension author, and my extension also has a REPL Webview. Right now I have to avoid providing default keybindings with chords ending in a typeable character. This is bad, because a lot of the commands for my extension make total sense to use with chords ending in regular characters.

This is extra bad because I also have to instruct my users to do avoid chords like that, regardless if the shortcut is related to my extension or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.