Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcut chords can be quietly overridden #88488

Closed
derekyle opened this issue Jan 11, 2020 · 6 comments
Closed

Keyboard shortcut chords can be quietly overridden #88488

derekyle opened this issue Jan 11, 2020 · 6 comments

Comments

@derekyle
Copy link

@derekyle derekyle commented Jan 11, 2020

Issue Type: Bug

I had an issue where none of my keyboard shortcut chords that started with Ctrl + K worked correctly. I finally discovered that it was because I had an extension that was triggered with Ctrl + K alone. The extension action was context dependent so it would never trigger and tip me off to the problem.

Allowing the first part of a chord to be set to an action negates all other chords that start with that combo. So it seems that vs code should warn or not allow this. I finally solved it by manually searching through all the shortcuts with ctrl + k in them and found the one that was just ctrl + k by itself and removed.

VS Code version: Code 1.41.1 (26076a4, 2019-12-18T14:58:56.166Z)
OS version: Windows_NT x64 10.0.18362

@vscodebot
Copy link

@vscodebot vscodebot bot commented Jan 11, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@alexdima
Copy link
Member

@alexdima alexdima commented Jan 20, 2020

I can see how this is highly annoying. But please create an issue against the extension. It is bad practice for an extension to ship with a keybinding which overrides tens of chords.

As far as VS Code goes, this is as designed. All the default VS Code keybindings can be overwritten from extensions. In fact, that is how the VS Code keymap extensions work, they change tens and hundreds of default keybindings, including chords, etc.

In this specific case, you did the perfect thing, you searched for "Ctrl+K" in the keybindings UI and found the culprit. Please create an issue against the extension.

@alexdima alexdima closed this Jan 20, 2020
@derekyle
Copy link
Author

@derekyle derekyle commented Jan 20, 2020

@alexdima
Copy link
Member

@alexdima alexdima commented Jan 20, 2020

@sandy081 In this case, when using cmd+k I see that we show "1 existing command..." but it should show a lot larger number, to include all the chords at cmd+k as well:

Kapture 2020-01-20 at 21 32 30

@alexdima alexdima reopened this Jan 20, 2020
@alexdima alexdima assigned sandy081 and unassigned alexdima Jan 20, 2020
@sandy081
Copy link
Member

@sandy081 sandy081 commented Jan 23, 2020

/duplicate

#88122

@vscodebot vscodebot bot added the *duplicate label Jan 23, 2020
@vscodebot
Copy link

@vscodebot vscodebot bot commented Jan 23, 2020

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this Jan 23, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.