Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger variable inspection splits variables through $ #89332

Closed
alexandercerutti opened this issue Jan 27, 2020 · 4 comments
Closed

Debugger variable inspection splits variables through $ #89332

alexandercerutti opened this issue Jan 27, 2020 · 4 comments
Assignees
Milestone

Comments

@alexandercerutti
Copy link

@alexandercerutti alexandercerutti commented Jan 27, 2020

  • VSCode Version + OS Version:
Version: 1.41.1
Commit: 26076a4de974ead31f97692a0d32f90d735645c0
Date: 2019-12-18T14:57:51.166Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Darwin x64 19.2.0

But this happens also on previous releases (I was experiencing this on vscode <= 1.30.x )

Steps to Reproduce:

  1. Write Javascript/Typescript code with an object that has a property with a dollar sign somewhere in the middle of its name.
  2. Enter in debug mode and put the mouse on that variable. First part will result as undefined, the second part will match all the variable. Look at the gif.
    It is not a great problem, but it may be error prone, as one might put the mouse above, assuming that it is read as one variable.

report2

Debug sidebar only shows one variable (the complete one) as the hover window.

If this is done with a code like this:

const myvar$x = 5;
console.log(myvar$x);

Debugging myvar$x only shows the value 5 if the mouse is on x, but does not show anything on myvar$

Does this issue occur when all extensions are disabled?: I don't know. To debug this I'm using Google Chrome Extension. I had not the possibility to test it on a node application yet.

@gjsjohnmurray

This comment has been minimized.

Copy link
Contributor

@gjsjohnmurray gjsjohnmurray commented Jan 27, 2020

See #89084. Once that API lands and is adopted by debug providers it will be possible to fix this.

@alexandercerutti

This comment has been minimized.

Copy link
Author

@alexandercerutti alexandercerutti commented Jan 27, 2020

@gjsjohnmurray Yes, it should be related. The problem might be similar or the same to the comment that is linked inside that issue topic (about COBOL variables).

@weinand weinand added debug bug labels Jan 27, 2020
@weinand

This comment has been minimized.

Copy link
Member

@weinand weinand commented Jan 27, 2020

Even without the new API proposed in #89084 we could fix this by using a language-specific word definition in the current hover implementation.

@weinand

This comment has been minimized.

Copy link
Member

@weinand weinand commented Feb 18, 2020

/duplicate #89084

@weinand weinand added the *duplicate label Feb 18, 2020
@weinand weinand closed this Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.