Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text files: do not report dirty for readonly models #89405

Closed
bpasero opened this issue Jan 28, 2020 · 1 comment
Closed

Text files: do not report dirty for readonly models #89405

bpasero opened this issue Jan 28, 2020 · 1 comment
Assignees
Labels
debt Code quality issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jan 28, 2020

So far, whenever the model of a text file changes, we would report it as dirty to the user. However, for readonly file systems, this is not ideal because neither could the user have changed the model nor can it save it.

Examples for readonly file system providers are our very own Git file system provider that a user should never see dirty files from. Other examples include LiveShare readonly sessions.

A change should be made such as readonly file models never report dirty when the model changes.

@bpasero bpasero added debt Code quality issues verification-needed Verification of issue is requested labels Jan 28, 2020
@bpasero bpasero added this to the January 2020 milestone Jan 28, 2020
@bpasero bpasero self-assigned this Jan 28, 2020
@bpasero
Copy link
Member Author

bpasero commented Jan 28, 2020

Fixed via d108195

Verification:

  • install LiveShare
  • start a readonly collab session
  • join this session from another insiders run (via --user-data-dir <some other dir>)
  • type in the host
  • verify the guest sees no dirty indicator

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants