Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List items should have role 'listitem' #90876

Closed
isidorn opened this issue Feb 18, 2020 · 4 comments
Closed

List items should have role 'listitem' #90876

isidorn opened this issue Feb 18, 2020 · 4 comments

Comments

@isidorn
Copy link
Contributor

@isidorn isidorn commented Feb 18, 2020

Currently the list sets the role of each item to be treeitem here
This should only be done for the Tree, not for the list. List should use listitem. More details here

Tree that actually uses the list should probably pass the role treeitem as the getRole to the list it extends from.
@joaomoreno if you are busy let me know and I can look into this.

@isidorn

This comment has been minimized.

Copy link
Contributor Author

@isidorn isidorn commented Feb 18, 2020

We should also verify this nicely works with NVDA, since it is part of aria 1.1 spec.

@joaomoreno

This comment has been minimized.

Copy link
Member

@joaomoreno joaomoreno commented Feb 18, 2020

Sure, PR would be great.

@isidorn

This comment has been minimized.

Copy link
Contributor Author

@isidorn isidorn commented Feb 18, 2020

Sure. Assigning to this milestone and if I do not find time might get pushed out.

@isidorn isidorn added this to the February 2020 milestone Feb 18, 2020
@joaomoreno joaomoreno added the bug label Feb 21, 2020
isidorn added a commit that referenced this issue Feb 21, 2020
fixes #90876
@isidorn

This comment has been minimized.

Copy link
Contributor Author

@isidorn isidorn commented Feb 27, 2020

To verify

  1. Windows, turn on NVDA
  2. Open suggest box -> make sure that the suggestions do not have "Level 1" read ath the end
  3. Open explorer -> make sure the items have appropriate Level read at the end
@connor4312 connor4312 added the verified label Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.