Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts are too verbose when problems panel is open. #91166

Closed
pawelurbanski opened this issue Feb 21, 2020 · 2 comments
Closed

Alerts are too verbose when problems panel is open. #91166

pawelurbanski opened this issue Feb 21, 2020 · 2 comments
Assignees
Milestone

Comments

@pawelurbanski
Copy link
Contributor

@pawelurbanski pawelurbanski commented Feb 21, 2020

  • VSCode Version: 1.42.1 - 1.43.0
  • OS Version: Windows 10 Version 1909 (OS Build 18363.657)

Steps to Reproduce:

  1. Open a file and toggle problems panel
  2. Start coding and introduce some error
  3. Remove all the errors from teh current file or workspace
  • The screen reader will be reading every possible change reflected in the panel,
  • Namely announcing the number of problems or lack of them,
  • Those alerts are read after every keystroke which changes the number of problems shown

Does this issue occur when all extensions are disabled?: Yes/No
Yes it does - takes place regardless.

A solution to the problem:

The panel view message box, which displays constantly changing values has the aria-live attribute. It makes the screen reader read out every change.
This information is useless for only after focusing to the panel treeview one can do anything about them.
Remove this attribute located in this place:

this.ariaLabelElement.setAttribute('aria-live', 'polite');

There will not be this spammy behavior. All the values for the number of problems found will still be available when toggling focus between the editor and the problems panel view.

@isidorn I skipped creating a full PR, since it is just a single line change anyone on the team can do. Should take less time than merging a PR.

@isidorn isidorn self-assigned this Feb 25, 2020
@isidorn

This comment has been minimized.

Copy link
Contributor

@isidorn isidorn commented Feb 25, 2020

This makes snese to me. And we can remove the aria-live attribute.
@sandy081 let me know if you do not mind and I will just remove that code line?

@sandy081

This comment has been minimized.

Copy link
Member

@sandy081 sandy081 commented Feb 26, 2020

👍 Please go ahead.

@isidorn isidorn closed this in e284936 Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.