Use the UndoRedoService for CustomEditors #92408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For microsoft#90110 Changes custom editors (the ones not based on text) to use the UndoRedoService. This involved: - Moving edit lifecycle back into the main process again (this is actually the bulk of the changes) - Removing the `undo`/`redo` methods on `CustomEditorModel` - Using the undoRedoService to trigger undo/redo
alexdima
approved these changes
Mar 11, 2020
There was a problem hiding this comment.
I have focused on the call to the undo-redo service. And that looks OK, just a small nitpick regarding the label (see other comment).
There is one thing missing here, I would have expected to see also a call to IUndoRedoService.removeElements. That call should be done to clear the undo/redo stack elements when a file gets closed, etc... in order to avoid a memory leak
| this._undoService.pushElement({ | ||
| type: UndoRedoElementType.Resource, | ||
| resource: this.resource, | ||
| label: 'Undo', |
There was a problem hiding this comment.
This label will be used in the context "Undo {0}", so it would be better if it was called "Edit", because now it might be presented as "Undo Undo"
There was a problem hiding this comment.
Thanks for clarifying. I'll also investigate getting the label from extensions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #90110
Changes custom editors (the ones not based on text) to use the UndoRedoService. This involved:
undo/redomethods onCustomEditorModelsince they are no longer requiredUndoRedoServiceto trigger undo/redo