Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes editor has wrong height when toggling tabs with breadcrumbs visible #97502

Merged
merged 3 commits into from May 12, 2020

Conversation

jeanp413
Copy link
Contributor

This PR fixes #97021

@jeanp413 jeanp413 marked this pull request as ready for review May 11, 2020 14:47
@jrieken jrieken requested a review from bpasero May 12, 2020 10:26
@bpasero bpasero merged commit 4c467c1 into microsoft:master May 12, 2020
@bpasero bpasero added this to the May 2020 milestone May 12, 2020
@bpasero
Copy link
Member

bpasero commented May 12, 2020

Thanks. I made changes on top to make this simpler: instead of calling layout from redraw, simply relayout when we detect the options change.

@jeanp413 jeanp413 deleted the fix-97021 branch May 12, 2020 16:20
@jeanp413
Copy link
Contributor Author

Awesome, much better 👍
Maybe some calls to relayout in tabsTitleControl are redundant now

private updateBreadcrumbsControl(): void {
if (this.breadcrumbsControl && this.breadcrumbsControl.update()) {
// relayout when we have a breadcrumbs and when update changed
// its hidden-status
this.group.relayout();
}

@bpasero
Copy link
Member

bpasero commented May 13, 2020

@jeanp413 not sure. the code I touched handles the transition between tabs being enabled or not while that method is about enabling breadcrumbs or not. I still think both cases need layout calls individually.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor has wrong height when toggling tabs with breadcrumbs visible
3 participants