Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes terminal Env Variables Icon Not Updating Position #98015

Merged
merged 2 commits into from Jun 11, 2020
Merged

Fixes terminal Env Variables Icon Not Updating Position #98015

merged 2 commits into from Jun 11, 2020

Conversation

jeanp413
Copy link
Contributor

This PR fixes #97927

The dimensions argument passed to the this.layout call inside the timeout were outdated.

Tyriar
Tyriar approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems to work. The layout code could do with a clean up at some point but in the meantime this doesn't seem like it would harm anything.

@Tyriar Tyriar added this to the June 2020 milestone Jun 11, 2020
@Tyriar Tyriar merged commit dcc0c13 into microsoft:master Jun 11, 2020
@jeanp413 jeanp413 deleted the fix-97927 branch June 11, 2020 14:30
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
June 2020
Development

Successfully merging this pull request may close these issues.

Terminal Env Variables Icon Not Updating Position
2 participants
@jeanp413 @Tyriar