Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call hierarchy: allow to remove nodes #98155

Closed
bpasero opened this issue May 19, 2020 · 5 comments
Closed

Call hierarchy: allow to remove nodes #98155

bpasero opened this issue May 19, 2020 · 5 comments
Assignees
Labels
callhierarchy feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities verification-needed Verification of issue is requested verified Verification succeeded

Comments

@bpasero
Copy link
Member

bpasero commented May 19, 2020

Similar to "Find References", allow me to remove individual nodes from the call graph, e.g. to exclude references that I reviewed (or from tests).

image

@jrieken jrieken added feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities labels May 19, 2020
@jrieken jrieken added this to the Backlog milestone May 19, 2020
@babakks
Copy link
Contributor

babakks commented May 22, 2020

I'd like to work on this.

Is there any note/tip that I'd be better aware of?

@mitchell-frost
Copy link

I am new here. Can I work on this?

@jrieken
Copy link
Member

jrieken commented May 26, 2020

@babakks was first

The sources are in a separate extension here: https://github.com/microsoft/vscode-references-view/blob/846367409ec890e3415c919db772c3fbfe01f41e/src/extension.ts#L356

There is already a command that can remove references (from find references, find implementations etc) and that must be extended to also support the call hierarchy model

@babakks
Copy link
Contributor

babakks commented Jun 3, 2020

@jrieken I've made the PR.

@jrieken jrieken modified the milestones: Backlog, September 2020 Sep 8, 2020
@jrieken
Copy link
Member

jrieken commented Sep 8, 2020

Done. Thanks @babakks

@jrieken jrieken closed this as completed Sep 8, 2020
@jrieken jrieken added the verification-needed Verification of issue is requested label Sep 28, 2020
@bpasero bpasero added the verified Verification succeeded label Sep 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
callhierarchy feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants