Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Color : Git : Staged #99129

Closed
RichardFevrier opened this issue Jun 2, 2020 · 7 comments · Fixed by #107318
Closed

Theme Color : Git : Staged #99129

RichardFevrier opened this issue Jun 2, 2020 · 7 comments · Fixed by #107318
Assignees
Labels
feature-request Request for new features or functionality git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded

Comments

@RichardFevrier
Copy link

For better visibility it would be nice to add different color settings for "staged" files.
Like:

  • "gitDecoration.stagedModifiedResourceForeground"
  • "gitDecoration.stagedAddedResourceForeground"
@joaomoreno
Copy link
Member

Can you show me a screenshot of the UI piece you would like to be able to theme?

@joaomoreno joaomoreno added the info-needed Issue requires more information from poster label Jun 3, 2020
@RichardFevrier
Copy link
Author

Thank you for your answer. Here are two screenshots.

Initial context: Git is configured in my current project. I have made modifications on some files. I have added some files in the index (git add filename) so those files are in a staged state, prepared for the next commit. Some others are just modified.

  • The first one is the "Source Control: Git" view. You can see the color on the right (on the "M") that is actually controlled by only one setting: "gitDecoration.modifiedResourceForeground" and it is yellow in this example. So we can't differentiate staged and non staged files.
  • The second is the "Explorer" view. You can see the same color controlled by the same setting as the name of the file (blurred but still yellow).

So to be able to differentiate "added", "modified", "added staged" and "modified staged" we need to add two settings:

  • "gitDecoration.stagedModifiedResourceForeground"
  • "gitDecoration.stagedAddedResourceForeground"

main_full

main_full-2

@joaomoreno joaomoreno added feature-request Request for new features or functionality git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities and removed info-needed Issue requires more information from poster labels Jun 4, 2020
@joaomoreno joaomoreno added this to the Backlog milestone Jun 4, 2020
@mohtamba
Copy link

mohtamba commented Jun 5, 2020

Hi, I would be interested in working on this feature.

@alexyu0610
Copy link

Hi I'm interested in working on this too! Been a VS code user for a while, find this feature useful!

codingonHP added a commit to codingonHP/vscode that referenced this issue Jun 14, 2020
Introduce a new status 'S' and corresponding theme color to easily identify resources that are staged
in git and explorer view.
@mwood77
Copy link
Contributor

mwood77 commented Sep 23, 2020

Hi! @joaomoreno I've created a pull request for this issue: #107318

@joaomoreno joaomoreno modified the milestones: Backlog, September 2020 Sep 28, 2020
@joaomoreno joaomoreno added the verification-needed Verification of issue is requested label Sep 28, 2020
@joaomoreno
Copy link
Member

Verification

As a theme author, you should be able to color staged modifications and deletions independently from unstaged ones.

@isidorn isidorn added the verified Verification succeeded label Sep 29, 2020
@isidorn
Copy link
Contributor

isidorn commented Sep 29, 2020

I have verified there is the following color
gitDecoration.stagedModifiedResourceForeground
However the other one seems to be gitDecoration.addedResourceForeground"

Both of these colors work fine when I change them via workbench.colorCusomtisations -> verified

Screenshot 2020-09-29 at 17 55 37

@joaomoreno joaomoreno added the on-release-notes Issue/pull request mentioned in release notes label Oct 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
7 participants
@joaomoreno @isidorn @RichardFevrier @alexyu0610 @mwood77 @mohtamba and others