Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated autoImports description #104207

Closed
wants to merge 1 commit into from

Conversation

epiacentini
Copy link
Contributor

@epiacentini epiacentini commented Aug 6, 2020

This PR fixes autoImports Description

@ghost
Copy link

ghost commented Aug 6, 2020

CLA assistant check
All CLA requirements met.

@@ -62,7 +62,7 @@
"configuration.tsserver.experimental.enableProjectDiagnostics": "(Experimental) Enables project wide error reporting.",
"typescript.locale": "Sets the locale used to report JavaScript and TypeScript errors. Requires using TypeScript 2.6.0 or newer in the workspace. Default of `null` uses VS Code's locale.",
"javascript.implicitProjectConfig.experimentalDecorators": "Enable/disable `experimentalDecorators` for JavaScript files that are not part of a project. Existing jsconfig.json or tsconfig.json files override this setting. Requires using TypeScript 2.3.1 or newer in the workspace.",
"configuration.suggest.autoImports": "Enable/disable auto import suggestions. Requires using TypeScript 2.6.1 or newer in the workspace.",
"configuration.suggest.autoImports": "Enable/disable auto import suggestions. Requires using TypeScript 3.0 or newer in the workspace.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in #104178, the suggested fix it to remove the entire Requires using TypeScript 2.6.1 or newer in the workspace. line

We'd also like the same for all settings that require a version of TypeScript that is less than 3.0

Copy link
Contributor

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you have any questions about my comment.

Also make sure to remove the yarn file from the change

@epiacentini
Copy link
Contributor Author

Let me know if you have any questions about my comment.

Also make sure to remove the yarn file from the change

Oh I understand now. Will do that now

@mjbvz
Copy link
Contributor

mjbvz commented Aug 11, 2020

Fixed by #104211 instead

@mjbvz mjbvz closed this Aug 11, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants