Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for running tsec #105748

Merged
merged 1 commit into from Sep 1, 2020
Merged

Add script for running tsec #105748

merged 1 commit into from Sep 1, 2020

Conversation

annkamsk
Copy link
Contributor

This PR fixes #105747. It adds a tsec as a devDependency and a "tsec-compile-check" script for running it on the VSCode's codebase.
For now, the added devDependency points to tsec github repository. This should be replaced within a week with an npm package name – as soon as we add tsec to npm.

Usage is very straightforward. After installing the missing dependency, a tsec compile check can be started with:
yarn tsec-compile-check
The run might take a while (up to 1 minute on an average computer). At the end, there should be several (44 as of now) compilation errors displayed with a fragment of violating code and a source of violation.

image

@mjbvz mjbvz assigned jrieken and unassigned mjbvz Aug 31, 2020
@jrieken jrieken added this to the September 2020 milestone Sep 1, 2020
@jrieken jrieken added the engineering VS Code - Build / issue tracking / etc. label Sep 1, 2020
@jrieken jrieken modified the milestones: September 2020, August 2020 Sep 1, 2020
@jrieken
Copy link
Member

jrieken commented Sep 1, 2020

lgtm - merging

@jrieken jrieken merged commit 6b39769 into microsoft:master Sep 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trusted Types compatibility: script for identifying violations
3 participants